You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2026/01/08 00:06:02 UTC

[PR] GH-48770: [CI] Add missing permissions declaration to check_labels.yml [arrow]

HyukjinKwon opened a new pull request, #48771:
URL: https://github.com/apache/arrow/pull/48771

   ### Rationale for this change
   
   Adds missing `permissions:` declaration to `check_labels.yml` workflow, following the security best practices (see also #35708).
   
   ### What changes are included in this PR?
   
   Adds workflow-level permissions to `check_labels.yml.
   
   ### Are these changes tested?
   
   Will be tested through CI.
   
   ### Are there any user-facing changes?
   
   No, dev-only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48770: [CI] Add missing permissions declaration to workflows [arrow]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48771:
URL: https://github.com/apache/arrow/pull/48771#issuecomment-3721668804

   Let me try to run them in this PR .. one sec ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48770: [CI] Add missing permissions declaration to workflows [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #48771:
URL: https://github.com/apache/arrow/pull/48771#issuecomment-3721628604

   Hmm... Why extra CI jobs aren't run...?
   
   Anyway, could you add this?
   
   ```diff
   diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml
   index 612175e60f..4b2290d077 100644
   --- a/.github/workflows/cpp_extra.yml
   +++ b/.github/workflows/cpp_extra.yml
   @@ -26,6 +26,7 @@ on:
          - '.dockerignore'
          - '.github/workflows/check_labels.yml'
          - '.github/workflows/cpp_extra.yml'
   +      - '.github/workflows/cpp_windows.yml'
          - '.github/workflows/report_ci.yml'
          - 'ci/conda_env_*'
          - 'ci/docker/**'
   @@ -47,6 +48,7 @@ on:
          - '.dockerignore'
          - '.github/workflows/check_labels.yml'
          - '.github/workflows/cpp_extra.yml'
   +      - '.github/workflows/cpp_windows.yml'
          - '.github/workflows/report_ci.yml'
          - 'ci/conda_env_*'
          - 'ci/docker/**'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48770: [CI] Add missing permissions declaration to workflows [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48771:
URL: https://github.com/apache/arrow/pull/48771#issuecomment-3723570370

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit fdeac0b98314ae3c626ce1dc01ad24d2ab26e021.
   
   There weren't enough matching historic benchmark results to make a call on whether there were regressions.
   
   The [full Conbench report](https://github.com/apache/arrow/runs/59792414119) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48770: [CI] Add missing permissions declaration to workflows [arrow]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48771:
URL: https://github.com/apache/arrow/pull/48771#issuecomment-3721760833

   Tests passed at https://github.com/apache/arrow/pull/48771/commits/573d53f2c2434297dcb65bbb2671407f6edacf66. Should be good to have a look!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48770: [CI] Add missing permissions declaration to workflows [arrow]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48771:
URL: https://github.com/apache/arrow/pull/48771#issuecomment-3722314796

   Let me open another quick PR and see if this is triggered.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48770: [CI] Add missing permissions declaration to check_labels.yml [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48771:
URL: https://github.com/apache/arrow/pull/48771#issuecomment-3721335435

   :warning: GitHub issue #48770 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48770: [CI] Add missing permissions declaration to workflows [arrow]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #48771:
URL: https://github.com/apache/arrow/pull/48771#discussion_r2670502623


##########
.github/workflows/report_ci.yml:
##########
@@ -20,6 +20,10 @@ name: Report CI results
 on:
   workflow_call:
 
+permissions:
+  actions: read
+  contents: read

Review Comment:
   Required by `actions/checkout`



##########
.github/workflows/cpp_windows.yml:
##########
@@ -33,6 +33,9 @@ on:
         required: true
         type: string
 
+permissions:
+  contents: read

Review Comment:
   Required by `actions/checkout`



##########
.github/workflows/report_ci.yml:
##########
@@ -20,6 +20,10 @@ name: Report CI results
 on:
   workflow_call:
 
+permissions:
+  actions: read

Review Comment:
   Required by `archery ci report-email` and `archery ci report-chat`



##########
.github/workflows/check_labels.yml:
##########
@@ -32,6 +32,10 @@ on:
         description: "Whether to force running the jobs"
         value: ${{ jobs.check-labels.outputs.force }}
 
+permissions:
+  contents: read

Review Comment:
   Required by `actions/checkout`
   Required by `gh pr view`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48770: [CI] Add missing permissions declaration to workflows [arrow]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48771:
URL: https://github.com/apache/arrow/pull/48771#issuecomment-3721632757

   Sure!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-48770: [CI] Add missing permissions declaration to workflows [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #48771:
URL: https://github.com/apache/arrow/pull/48771


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org