[GitHub] [helix] dasahcc commented on a change in pull request #1326: Task Framework IdealState Removal

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r481358790



##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java
##########
@@ -98,6 +101,43 @@ public void process(ClusterEvent event) throws Exception {
       }
     }
 
+    // Add TaskFramework resources from workflow and job configs as Task Framework will no longer
+    // use IdealState
+    if (isTaskCache) {

Review comment:
       Do we need this? We already based on all Workflows to do the assignment. Originally have this is for backward compatible change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org