You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/03/08 22:27:49 UTC

[kudu-CR] master: plumb metric for master leadership 

Hello Adar Dembo,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15386

to review the following change.


Change subject: master: plumb metric for master leadership
......................................................................

master: plumb metric for master leadership

Change-Id: Ie6972a1b9f803e3e4f293c67b035f5e924c67df2
---
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/master/sys_catalog.cc
2 files changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/15386/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6972a1b9f803e3e4f293c67b035f5e924c67df2
Gerrit-Change-Number: 15386
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] master: plumb metric for master leadership

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15386 )

Change subject: master: plumb metric for master leadership
......................................................................

master: plumb metric for master leadership

Change-Id: Ie6972a1b9f803e3e4f293c67b035f5e924c67df2
Reviewed-on: http://gerrit.cloudera.org:8080/15386
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/master/sys_catalog.cc
2 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6972a1b9f803e3e4f293c67b035f5e924c67df2
Gerrit-Change-Number: 15386
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] master: plumb metric for master leadership

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15386 )

Change subject: master: plumb metric for master leadership
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15386/1/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/15386/1/src/kudu/master/sys_catalog.cc@408
PS1, Line 408:                                                  master_->num_raft_leaders(),
> Huh. If this was so simple, why didn't we do it earlier?
Yeah, I think when I first wrote the TODO, the plumbing wasn't as straightforward (eg it might've been in the tserver instead of kserver, and the comment here was counting on the move).



-- 
To view, visit http://gerrit.cloudera.org:8080/15386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6972a1b9f803e3e4f293c67b035f5e924c67df2
Gerrit-Change-Number: 15386
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sun, 08 Mar 2020 22:55:59 +0000
Gerrit-HasComments: Yes

[kudu-CR] master: plumb metric for master leadership

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15386 )

Change subject: master: plumb metric for master leadership
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15386/1/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/15386/1/src/kudu/master/sys_catalog.cc@408
PS1, Line 408:                                                  master_->num_raft_leaders(),
Huh. If this was so simple, why didn't we do it earlier?



-- 
To view, visit http://gerrit.cloudera.org:8080/15386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6972a1b9f803e3e4f293c67b035f5e924c67df2
Gerrit-Change-Number: 15386
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sun, 08 Mar 2020 22:33:09 +0000
Gerrit-HasComments: Yes