You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/09 11:47:08 UTC

[GitHub] [flink-connector-pulsar] MartijnVisser commented on a diff in pull request #4: [FLINK-30336][BP 3.0] Sync missing e2e tests

MartijnVisser commented on code in PR #4:
URL: https://github.com/apache/flink-connector-pulsar/pull/4#discussion_r1044377052


##########
.github/workflows/ci.yml:
##########
@@ -32,6 +32,10 @@ on:
         required: true
         type: boolean
 
+concurrency:
+  group: pr-${{ github.ref }}

Review Comment:
   Based on https://stackoverflow.com/questions/70928424/limit-github-action-workflow-concurrency-on-push-and-pull-request I would guess we should make it `group: ${{ github.head_ref || github.ref_name }}` and move this to `push_pr.yml`. 
   
   I'll update the PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org