[GitHub] [airflow] mik-laj commented on a change in pull request #7583: [AIRFLOW-6954] Use DagRunType instead of ID_PREFIX in run_id

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #7583: [AIRFLOW-6954] Use DagRunType instead of ID_PREFIX in run_id
URL: https://github.com/apache/airflow/pull/7583#discussion_r385648477
 
 

 ##########
 File path: airflow/models/dagrun.py
 ##########
 @@ -97,12 +94,11 @@ def set_state(self, state):
 
     @declared_attr
     def state(self):
-        return synonym('_state',
-                       descriptor=property(self.get_state, self.set_state))
+        return synonym('_state', descriptor=property(self.get_state, self.set_state))
 
     @classmethod
-    def id_for_date(cls, date, prefix=ID_FORMAT_PREFIX):
-        return prefix.format(date.isoformat()[:19])
+    def id_for_date(cls, date, prefix=DagRunType.SCHEDULED.value):
 
 Review comment:
   Why do we need this method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services