[jira] [Assigned] (OAK-5557) incomplete diffManyChildren during commitHook evaluation in a persisted branch

["Marcel Reutegger (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger reassigned OAK-5557:
-------------------------------------

    Assignee: Marcel Reutegger  (was: Stefan Egli)

> incomplete diffManyChildren during commitHook evaluation in a persisted branch
> ------------------------------------------------------------------------------
>
>                 Key: OAK-5557
>                 URL: https://issues.apache.org/jira/browse/OAK-5557
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, documentmk
>    Affects Versions: 1.2.23, 1.4.12, 1.6.0
>         Environment: 'easily' reproducible on 1.2.14
> 'takes longer to' reproduce on 1.2.23
>            Reporter: Stefan Egli
>            Assignee: Marcel Reutegger
>              Labels: candidate_oak_1_2, candidate_oak_1_4, candidate_oak_1_6
>             Fix For: 1.7.0, 1.8
>
>         Attachments: DocumentNodeStoreBranchesTest.java, DocumentNodeStoreBranchesTest.java, OAK-5557-1.2.patch, OAK-5557.patch
>
>
> In oak 1.2 when doing a diffManyChildren as part of running the CommitHooks as part of a branch commit, not all child paths are taken into account in some cases.
> The problem seems to be related to the [{{_modified}} calculation|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.2.14/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java#L2242] when doing the query for affected child paths. It seems [that {{minValue}}|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.2.14/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java#L2242] is not correctly calculated when doing {{compareAgainstBaseState}} as part of a persisted branch.
> Note that the problem can be reproduced very good on 1.2.14, less good but still on the latest 1.2 and not in trunk (ie almost 1.6.0).
> Attaching a test case to reproduce



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)