You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@stratos.apache.org by R-Rajkumar <gi...@git.apache.org> on 2014/08/26 11:06:30 UTC

[GitHub] stratos pull request: removing unwanted strings in jaggery console...

GitHub user R-Rajkumar opened a pull request:

    https://github.com/apache/stratos/pull/18

    removing unwanted strings in jaggery console app's tenant_management.js

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/R-Rajkumar/stratos master-jaggery

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/stratos/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18
    
----
commit d5e42abba074cd0d3c5254ab8a435388a2bf38d5
Author: R-Rajkumar <rr...@gmail.com>
Date:   2014-08-26T09:04:29Z

    removing unwanted strings in tenant_management.js

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: removing unwanted strings in jaggery console...

Posted by R-Rajkumar <gi...@git.apache.org>.

Github user R-Rajkumar commented on the pull request:

    https://github.com/apache/stratos/pull/18#issuecomment-53402572
  
    picked the correct one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: removing unwanted strings in jaggery console...

Posted by R-Rajkumar <gi...@git.apache.org>.

Github user R-Rajkumar closed the pull request at:

    https://github.com/apache/stratos/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] stratos pull request: removing unwanted strings in jaggery console...

Posted by Udara Liyanage <ud...@wso2.com>.

Hi,

It should be as below. There is no issue in removing help text since it is
not showing. But feel better to keep it since it may be usefull in future.

bamInfo:data.bamInfo,
has_help: false,
help: 'Create cartridges like PHP, Python, Ruby etc.. Or create data
cartridges with mySql, PostgreSQL. Directly install applications like
Drupal, Wordpress etc..'

<https://github.com/R-Rajkumar/stratos/commit/349b273b5415519caff81b2c0e58047bdacf7f77#diff-563bf23e714ba7eddbb1b0f33427d16bR90>

On Tue, Aug 26, 2014 at 2:51 PM, shirolk <gi...@git.apache.org> wrote:

> Github user shirolk commented on the pull request:
>
>     https://github.com/apache/stratos/pull/18#issuecomment-53395260
>
>     These extra lines have come in due to a merge and AFAIS(ee)in addition
> to removing these need to pick the correct block as well - i.e. between
>      has_help:false,
>     or
>      bamInfo:data.bamInfo,
>      has_help: true,
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

-- 

Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware

web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897

[GitHub] stratos pull request: removing unwanted strings in jaggery console...

Posted by shirolk <gi...@git.apache.org>.

Github user shirolk commented on the pull request:

    https://github.com/apache/stratos/pull/18#issuecomment-53395260
  
    These extra lines have come in due to a merge and AFAIS(ee)in addition to removing these need to pick the correct block as well - i.e. between 
     has_help:false,
    or
     bamInfo:data.bamInfo,
     has_help: true,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---