[GitHub] [airflow] alex-astronomer commented on pull request #18438: Add muldelete action to TaskInstanceModelView and tests. Change permissions for TaskInstanceModelView.action_clear to "delete"

[GitBox <gi...@apache.org>]

alex-astronomer commented on pull request #18438:
URL: https://github.com/apache/airflow/pull/18438#issuecomment-925922671


   > > People will be able to delete TaskInstances that the person should not have access too.
   > 
   > I created a PR to add a test to avoid the security issue in the future: #18467.
   > Please don't take my comment the wrong way, I appreciate the work you are doing and thing it is a clean implementation ✌️.
   > I should have written this test earlier and it's my mistake this wasn't made clear by the tests.
   
   No offense taken, I'm happy that you commented because now I can learn something from this.  I was wondering how I missed something like that since I just referred to the DagRun equivalent of the muldelete function but it looks like that decorator was added 2 days ago and I just wasn't up to date on my main branch.  Good catch.  I'm going to add that now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org