[jira] [Resolved] (KAFKA-10092) Remove unnecessary enum modifier in NioEchoServer

["Chia-Ping Tsai (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chia-Ping Tsai resolved KAFKA-10092.
------------------------------------
    Fix Version/s: 2.8.0
       Resolution: Fixed

> Remove unnecessary enum modifier in NioEchoServer
> -------------------------------------------------
>
>                 Key: KAFKA-10092
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10092
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Andrey Falko
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 2.8.0
>
>
> n.b. This is a newbie ticket designed to be an introduction to contributing for the assignee.  
> In NioEchoServer the enum has its constructor declared as private, which is [redundant|https://docs.oracle.com/javase/tutorial/java/javaOO/enum.html].  We can remove this.  
> {code}public class NioEchoServer extends Thread {
>     public enum MetricType {
>         TOTAL, RATE, AVG, MAX;
>         private final String metricNameSuffix;
>         private MetricType() {
>             metricNameSuffix = "-" + name().toLowerCase(Locale.ROOT);
>         }}} {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)