[GitHub] [pinot] sajjad-moradi commented on a diff in pull request #9544: Make StreamMessage generic and a bug fix

[GitBox <gi...@apache.org>]

sajjad-moradi commented on code in PR #9544:
URL: https://github.com/apache/pinot/pull/9544#discussion_r989730710


##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMessage.java:
##########
@@ -38,25 +38,31 @@
  * Additionally, the pinot table schema should refer these fields. Otherwise, even though the fields are extracted,
  * they will not materialize in the pinot table.
  */
-public class StreamMessage {
+public class StreamMessage<T> {
   private final byte[] _key;
-  private final byte[] _value;
+  private final T _value;
   protected final StreamMessageMetadata _metadata;
+  int _length = -1;
 
-  public StreamMessage(@Nullable byte[] key, byte[] value, @Nullable StreamMessageMetadata metadata) {
+  public StreamMessage(@Nullable byte[] key, T value, @Nullable StreamMessageMetadata metadata, int length) {
     _key = key;
     _value = value;
     _metadata = metadata;
+    _length = length;

Review Comment:
   Could you please update the javadoc for the new field?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org