[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5050: Flink: Support write options in the in-line insert SQL comments

[GitBox <gi...@apache.org>]

stevenzwu commented on code in PR #5050:
URL: https://github.com/apache/iceberg/pull/5050#discussion_r932830915


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java:
##########
@@ -37,6 +37,7 @@ public class IcebergTableSink implements DynamicTableSink, SupportsPartitioning,
   private final TableLoader tableLoader;
   private final TableSchema tableSchema;
   private final ReadableConfig readableConfig;
+  private final Map<String, String> tableProps;

Review Comment:
   let's not call it `tableProps` to avoid confusing with Iceberg table properties. Is `writeProps` more accurate? it would be consistent with the Javadoc of `setAll` from `FlinkSink#Builder`.
   
   ```
       /**
        * Set the write properties for Flink sink. View the supported properties in {@link
        * FlinkWriteOptions}
        */
       public Builder setAll(Map<String, String> properties) {
         writeOptions.putAll(properties);
         return this;
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org