[GitHub] [superset] john-bodley commented on a diff in pull request #20340: fix: ensure column name in description is string

[GitBox <gi...@apache.org>]

john-bodley commented on code in PR #20340:
URL: https://github.com/apache/superset/pull/20340#discussion_r894662043


##########
superset/result_set.py:
##########
@@ -71,6 +71,19 @@ def destringify(obj: str) -> Any:
     return json.loads(obj)
 
 
+def convert_to_string(value: Any) -> str:
+    """
+    Used to ensure column names from the cursor description are strings.
+    """
+    if isinstance(value, str):

Review Comment:
   Is this necessary? Isn’t the fallback suffice?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org