[jira] [Commented] (FLINK-4273) Refactor JobClientActor to watch already submitted jobs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399660#comment-15399660 ] 

ASF GitHub Bot commented on FLINK-4273:
---------------------------------------

GitHub user mxm opened a pull request:

    https://github.com/apache/flink/pull/2313

    [FLINK-4273] Modify JobClient to attach to running jobs

    These changes are required for FLINK-4272 (introduce a JobClient class
    for job control). Essentially, we want to be able to re-attach to a
    running job and monitor it. It shouldn't make any difference whether we
    just submitted the job or we recover it from an existing JobID.
    
    This PR modifies the JobClientActor to support two different operation
    modes: a) submitJob and monitor b) re-attach to job and monitor
    
    The JobClient class has been updated with methods to access this
    functionality. Before it just had `submitJobAndWait` and
    `submitJobDetachd`. Additionally, it has `submitJob` and
    `attachToRunningJob` and `awaitJobResult`.
    
    `submitJob` -> Submit job and return a future which can be completed to
    get the result with `awaitJobResult`
    
    `attachToRunningJob` -> Re-attached the JobClientActor to a runnning
    job, registering at the JobManager and downloading its class loader
    
    `awaitJobResult` -> Blocks until the returned future from either
    `submitJob` or `attachToRunningJob` has been completed
    
    TODO
    - missing integration test to test downloading of the user code
    class loader from the JobManager and to end-to-end test the
    re-attachment.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/flink FLINK-4273

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2313
    
----
commit 7832810728abea5824e2fe0d9e9dc75b14ef61af
Author: Maximilian Michels <mx...@apache.org>
Date:   2016-07-29T15:37:41Z

    [FLINK-4273] Modify JobClient to attach to running jobs
    
    These changes are required for FLINK-4272 (introduce a JobClient class
    for job control). Essentially, we want to be able to re-attach to a
    running job and monitor it. It shouldn't make any difference whether we
    just submitted the job or we recover it from an existing JobID.
    
    This PR modifies the JobClientActor to support two different operation
    modes: a) submitJob and monitor b) re-attach to job and monitor
    
    The JobClient class has been updated with methods to access this
    functionality. Before it just had `submitJobAndWait` and
    `submitJobDetachd`. Additionally, it has `submitJob` and
    `attachToRunningJob` and `awaitJobResult`.
    
    `submitJob` -> Submit job and return a future which can be completed to
    get the result with `awaitJobResult`
    
    `attachToRunningJob` -> Re-attached the JobClientActor to a runnning
    job, registering at the JobManager and downloading its class loader
    
    `awaitJobResult` -> Blocks until the returned future from either
    `submitJob` or `attachToRunningJob` has been completed
    
    TODO
    - missing integration test to test downloading of the user code
    class loader from the JobManager and to end-to-end test the
    re-attachment.

----


> Refactor JobClientActor to watch already submitted jobs 
> --------------------------------------------------------
>
>                 Key: FLINK-4273
>                 URL: https://issues.apache.org/jira/browse/FLINK-4273
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> The JobClientActor assumes that it receives a job, submits it, and waits for the result. This process should be broken up into a submission process and a waiting process which can both be entered independently. This leads to two different entry points:
> 1) submit(job) -> wait
> 2) retrieve(jobID) -> wait



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)