You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/04 22:26:04 UTC

[GitHub] [beam] pabloem commented on a change in pull request #11560: Auto-inferring project for ReadFromBigQuery

pabloem commented on a change in pull request #11560:
URL: https://github.com/apache/beam/pull/11560#discussion_r419765325



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -526,7 +526,7 @@ def reader(self, test_bigquery_client=None):
 
 
 def _to_bool(value):
-  return value == 'true'
+  return value

Review comment:
       the coder incorrectly expected boolean types to be encoded as strings. This is incorrect, as JSON supports boolean 'natively', like this: https://json-schema.org/understanding-json-schema/reference/boolean.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org