You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2017/02/09 16:56:59 UTC

[GitHub] zeppelin pull request #2001: ZEPPELIN-2057 Extract InterpreterSetting functi...

GitHub user jongyoul opened a pull request:

    https://github.com/apache/zeppelin/pull/2001

    ZEPPELIN-2057 Extract InterpreterSetting functions from InterpreterFactory

    ### What is this PR for?
    Reducing size of InterpreterFactory and divide some functions from InterpreterFactory. Currently, InterpreterFactory has a lot of functions including management on InterpreterSetting and interpreter processes. This PR extracts InterpreterSetting-related parts into `InterpreterSettingManager`. It also has two unrelated functions: InterpreterSetting and InterpreterGroup. I'll treat it with another PR. This PR has some mechanical changes because it can help understand which parts has been changed. I'll do refactoring them later. 
    
    ### What type of PR is it?
    [Refactoring]
    
    ### Todos
    * [x] - Extract all methods and variables related InterpreterSetting from InterpreterFactory
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2057
    
    ### How should this be tested?
    Works exactly as same before
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-2057

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2001.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2001
    
----
commit d985076d8a31b6cc65113064df202d8324507253
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2017-02-07T15:09:31Z

    ing...

commit 951ccc13205de21aa57c214e1de28101491878f0
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2017-02-09T16:48:19Z

    Extracted InterpreterSetting from InterpreterFactory

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2001: [WIP]ZEPPELIN-2057 Extract InterpreterSetting function...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2001
  
    generally looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2001: ZEPPELIN-2057 Extract InterpreterSetting functi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2001


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2001: [WIP]ZEPPELIN-2057 Extract InterpreterSetting function...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2001
  
    @zjffdu I won't change any interpreter protocol in these PRs. This refactoring PRs rearrange code and divide methods into several classes. The next step is to change interpreter management parts which are related to InterpreterGroup actually. Cluster management is not scope of these PRs. I'll share cluster management things with email or wiki docs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2001: [WIP]ZEPPELIN-2057 Extract InterpreterSetting function...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2001
  
    CI passed with https://travis-ci.org/jongyoul/zeppelin/builds/201829204 Will merge it if there's no further discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2001: [WIP]ZEPPELIN-2057 Extract InterpreterSetting function...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2001
  
    @jongyoul Do you have a design to share for the whole refactoring ? I think you would have a lot following up PR for the interpreter component refactoring. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---