[GitHub] [iceberg] rdblue commented on a change in pull request #2021: Add the cardinality check to detect ambiguous target row for MERGE INTO

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2021:
URL: https://github.com/apache/iceberg/pull/2021#discussion_r551472353



##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -164,4 +164,7 @@ private TableProperties() {
 
   public static final String MERGE_MODE = "write.merge.mode";
   public static final String MERGE_MODE_DEFAULT = "copy-on-write";
+
+  public static final String MERGE_WRITE_CARDINALITY_CHECK = "write.merge.cardinality.check.enabled";

Review comment:
       I like Anton's original suggestion better than this property. How about `write.merge.cardinality-check.enabled`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org