[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #4039: HADOOP-18146: ABFS: Added changes for expect hundred continue header

[GitBox <gi...@apache.org>]

mukund-thakur commented on code in PR #4039:
URL: https://github.com/apache/hadoop/pull/4039#discussion_r1004960913


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -688,6 +692,17 @@ public AbfsRestOperation append(final String path, final byte[] buffer,
     try {
       op.execute(tracingContext);
     } catch (AzureBlobFileSystemException e) {
+      /*
+        If the http response code indicates a user error we retry the same append request with expect header disabled.

Review Comment:
   thanks for adding comments. Use the // style of comments as written for method appendSuccessCheckOp() below. 
   Also the line lengths is too long I guess, looks off as compared to current codebase. please limit it to 100. 



##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java:
##########
@@ -320,6 +320,8 @@ public void sendRequest(byte[] buffer, int offset, int length) throws IOExceptio
       // accompanying statusCode
       this.bytesSent = length;
       outputStream.write(buffer, offset, length);
+    } catch (IOException e) {
+      this.bytesSent = length;

Review Comment:
   Why this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org