You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/01 20:23:57 UTC

[GitHub] [beam] robertwb commented on a change in pull request #16093: Cleanup default partitionings for dataframe helpers.

robertwb commented on a change in pull request #16093:
URL: https://github.com/apache/beam/pull/16093#discussion_r760543356



##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -160,8 +160,10 @@ def _proxy_method(
     restrictions=None,
     inplace=False,
     base=None,
-    requires_partition_by=partitionings.Singleton(),
-    preserves_partition_by=partitionings.Arbitrary()):
+    *,
+    requires_partition_by,  # type: partitionings.Partitioning
+    preserves_partition_by,  # type: partitionings.Partitioning

Review comment:
       Good point, though I think this cleanup should be done separately (and prefer to be consistent within a method/file). 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org