You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Kishan Kavala <Ki...@citrix.com> on 2013/03/13 18:36:50 UTC
Review Request: Removed the concept of owner region
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9905/
-----------------------------------------------------------
Review request for cloudstack, David Nalley and Chip Childers.
Description
-------
CLOUDSTACK-1636: Removed the concept of owner region.
Removed region_id from user/account and domain tables.
Removed forwarding of api calls to owner region.
Removed api_key and secret_key from region table.
Included related DB upgrade changes.
This addresses bug CLOUDSTACK-1636.
Diffs
-----
api/src/com/cloud/domain/Domain.java f8277c2
api/src/com/cloud/user/Account.java e65e017
api/src/com/cloud/user/AccountService.java f9c6ddb
api/src/com/cloud/user/DomainService.java 1f03019
api/src/com/cloud/user/User.java 7d80c43
api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 4121651
api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 5eae486
api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 2036670
api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 16693b6
api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 6ea8d9b
api/src/org/apache/cloudstack/region/Region.java 7f0aeea
api/src/org/apache/cloudstack/region/RegionService.java 8679ca9
api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 01cd33b
core/src/com/cloud/user/AccountVO.java fd37c77
core/src/com/cloud/user/UserVO.java de7f31b
server/src/com/cloud/domain/DomainVO.java 346e19f
server/src/com/cloud/projects/ProjectManagerImpl.java 33feb5d
server/src/com/cloud/upgrade/dao/Upgrade40to41.java 9268764
server/src/com/cloud/user/AccountManager.java 4b3a601
server/src/com/cloud/user/AccountManagerImpl.java 069ed2b
server/src/com/cloud/user/DomainManager.java f268f6e
server/src/com/cloud/user/DomainManagerImpl.java 9f0ad53
server/src/org/apache/cloudstack/region/RegionManager.java 4cbd664
server/src/org/apache/cloudstack/region/RegionManagerImpl.java 6b7bc16
server/src/org/apache/cloudstack/region/RegionServiceImpl.java 0662c32
server/src/org/apache/cloudstack/region/RegionVO.java 0c36db2
server/src/org/apache/cloudstack/region/RegionsApiUtil.java 2ace4f9
server/test/com/cloud/user/MockAccountManagerImpl.java b637c2a
server/test/com/cloud/user/MockDomainManagerImpl.java bc92965
server/test/org/apache/cloudstack/region/RegionManagerTest.java 330f0b4
setup/db/db/schema-40to410.sql 822eae3
Diff: https://reviews.apache.org/r/9905/diff/
Testing
-------
Tested account/user/domain api operations.
Tested deploydb and upgrade changed.
Thanks,
Kishan Kavala
Re: Review Request: Removed the concept of owner region
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9905/#review17939
-----------------------------------------------------------
pushed to 4.1
- Chip Childers
On March 13, 2013, 5:37 p.m., Kishan Kavala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9905/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 5:37 p.m.)
>
>
> Review request for cloudstack, David Nalley and Chip Childers.
>
>
> Description
> -------
>
> CLOUDSTACK-1636: Removed the concept of owner region.
> Removed region_id from user/account and domain tables.
> Removed forwarding of api calls to owner region.
> Removed api_key and secret_key from region table.
> Included related DB upgrade changes.
>
>
> This addresses bug CLOUDSTACK-1636.
>
>
> Diffs
> -----
>
> api/src/com/cloud/domain/Domain.java f8277c2
> api/src/com/cloud/user/Account.java e65e017
> api/src/com/cloud/user/AccountService.java f9c6ddb
> api/src/com/cloud/user/DomainService.java 1f03019
> api/src/com/cloud/user/User.java 7d80c43
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 4121651
> api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 5eae486
> api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 2036670
> api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 16693b6
> api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 6ea8d9b
> api/src/org/apache/cloudstack/region/Region.java 7f0aeea
> api/src/org/apache/cloudstack/region/RegionService.java 8679ca9
> api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 01cd33b
> core/src/com/cloud/user/AccountVO.java fd37c77
> core/src/com/cloud/user/UserVO.java de7f31b
> server/src/com/cloud/domain/DomainVO.java 346e19f
> server/src/com/cloud/projects/ProjectManagerImpl.java 33feb5d
> server/src/com/cloud/upgrade/dao/Upgrade40to41.java 9268764
> server/src/com/cloud/user/AccountManager.java 4b3a601
> server/src/com/cloud/user/AccountManagerImpl.java 069ed2b
> server/src/com/cloud/user/DomainManager.java f268f6e
> server/src/com/cloud/user/DomainManagerImpl.java 9f0ad53
> server/src/org/apache/cloudstack/region/RegionManager.java 4cbd664
> server/src/org/apache/cloudstack/region/RegionManagerImpl.java 6b7bc16
> server/src/org/apache/cloudstack/region/RegionServiceImpl.java 0662c32
> server/src/org/apache/cloudstack/region/RegionVO.java 0c36db2
> server/src/org/apache/cloudstack/region/RegionsApiUtil.java 2ace4f9
> server/test/com/cloud/user/MockAccountManagerImpl.java b637c2a
> server/test/com/cloud/user/MockDomainManagerImpl.java bc92965
> server/test/org/apache/cloudstack/region/RegionManagerTest.java 330f0b4
> setup/db/db/schema-40to410.sql 822eae3
>
> Diff: https://reviews.apache.org/r/9905/diff/
>
>
> Testing
> -------
>
> Tested account/user/domain api operations.
> Tested deploydb and upgrade changed.
>
>
> Thanks,
>
> Kishan Kavala
>
>
Re: Review Request: Removed the concept of owner region
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9905/#review17940
-----------------------------------------------------------
Ship it!
Ship It!
- Chip Childers
On March 13, 2013, 5:37 p.m., Kishan Kavala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9905/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 5:37 p.m.)
>
>
> Review request for cloudstack, David Nalley and Chip Childers.
>
>
> Description
> -------
>
> CLOUDSTACK-1636: Removed the concept of owner region.
> Removed region_id from user/account and domain tables.
> Removed forwarding of api calls to owner region.
> Removed api_key and secret_key from region table.
> Included related DB upgrade changes.
>
>
> This addresses bug CLOUDSTACK-1636.
>
>
> Diffs
> -----
>
> api/src/com/cloud/domain/Domain.java f8277c2
> api/src/com/cloud/user/Account.java e65e017
> api/src/com/cloud/user/AccountService.java f9c6ddb
> api/src/com/cloud/user/DomainService.java 1f03019
> api/src/com/cloud/user/User.java 7d80c43
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 4121651
> api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 5eae486
> api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 2036670
> api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 16693b6
> api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 6ea8d9b
> api/src/org/apache/cloudstack/region/Region.java 7f0aeea
> api/src/org/apache/cloudstack/region/RegionService.java 8679ca9
> api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 01cd33b
> core/src/com/cloud/user/AccountVO.java fd37c77
> core/src/com/cloud/user/UserVO.java de7f31b
> server/src/com/cloud/domain/DomainVO.java 346e19f
> server/src/com/cloud/projects/ProjectManagerImpl.java 33feb5d
> server/src/com/cloud/upgrade/dao/Upgrade40to41.java 9268764
> server/src/com/cloud/user/AccountManager.java 4b3a601
> server/src/com/cloud/user/AccountManagerImpl.java 069ed2b
> server/src/com/cloud/user/DomainManager.java f268f6e
> server/src/com/cloud/user/DomainManagerImpl.java 9f0ad53
> server/src/org/apache/cloudstack/region/RegionManager.java 4cbd664
> server/src/org/apache/cloudstack/region/RegionManagerImpl.java 6b7bc16
> server/src/org/apache/cloudstack/region/RegionServiceImpl.java 0662c32
> server/src/org/apache/cloudstack/region/RegionVO.java 0c36db2
> server/src/org/apache/cloudstack/region/RegionsApiUtil.java 2ace4f9
> server/test/com/cloud/user/MockAccountManagerImpl.java b637c2a
> server/test/com/cloud/user/MockDomainManagerImpl.java bc92965
> server/test/org/apache/cloudstack/region/RegionManagerTest.java 330f0b4
> setup/db/db/schema-40to410.sql 822eae3
>
> Diff: https://reviews.apache.org/r/9905/diff/
>
>
> Testing
> -------
>
> Tested account/user/domain api operations.
> Tested deploydb and upgrade changed.
>
>
> Thanks,
>
> Kishan Kavala
>
>
Re: Review Request: Removed the concept of owner region
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9905/
-----------------------------------------------------------
(Updated March 13, 2013, 5:37 p.m.)
Review request for cloudstack, David Nalley and Chip Childers.
Description
-------
CLOUDSTACK-1636: Removed the concept of owner region.
Removed region_id from user/account and domain tables.
Removed forwarding of api calls to owner region.
Removed api_key and secret_key from region table.
Included related DB upgrade changes.
This addresses bug CLOUDSTACK-1636.
Diffs
-----
api/src/com/cloud/domain/Domain.java f8277c2
api/src/com/cloud/user/Account.java e65e017
api/src/com/cloud/user/AccountService.java f9c6ddb
api/src/com/cloud/user/DomainService.java 1f03019
api/src/com/cloud/user/User.java 7d80c43
api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 4121651
api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 5eae486
api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 2036670
api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 16693b6
api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 6ea8d9b
api/src/org/apache/cloudstack/region/Region.java 7f0aeea
api/src/org/apache/cloudstack/region/RegionService.java 8679ca9
api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 01cd33b
core/src/com/cloud/user/AccountVO.java fd37c77
core/src/com/cloud/user/UserVO.java de7f31b
server/src/com/cloud/domain/DomainVO.java 346e19f
server/src/com/cloud/projects/ProjectManagerImpl.java 33feb5d
server/src/com/cloud/upgrade/dao/Upgrade40to41.java 9268764
server/src/com/cloud/user/AccountManager.java 4b3a601
server/src/com/cloud/user/AccountManagerImpl.java 069ed2b
server/src/com/cloud/user/DomainManager.java f268f6e
server/src/com/cloud/user/DomainManagerImpl.java 9f0ad53
server/src/org/apache/cloudstack/region/RegionManager.java 4cbd664
server/src/org/apache/cloudstack/region/RegionManagerImpl.java 6b7bc16
server/src/org/apache/cloudstack/region/RegionServiceImpl.java 0662c32
server/src/org/apache/cloudstack/region/RegionVO.java 0c36db2
server/src/org/apache/cloudstack/region/RegionsApiUtil.java 2ace4f9
server/test/com/cloud/user/MockAccountManagerImpl.java b637c2a
server/test/com/cloud/user/MockDomainManagerImpl.java bc92965
server/test/org/apache/cloudstack/region/RegionManagerTest.java 330f0b4
setup/db/db/schema-40to410.sql 822eae3
Diff: https://reviews.apache.org/r/9905/diff/
Testing
-------
Tested account/user/domain api operations.
Tested deploydb and upgrade changed.
Thanks,
Kishan Kavala