Re: [DISCUSS] KIP-1104: Allow Foreign Key Extraction from Both Key and Value in KTable Joins

["Matthias J. Sax" <mj...@apache.org>]

Seems you did link to the wrong KIP. Should be 
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1104%3A+Allow+Foreign+Key+Extraction+from+Both+Key+and+Value+in+KTable+Joins

:)

Overall the KIP does make sense and I don't have any comments. Seems to 
be quite clear.


-Matthias

On 10/30/24 10:08 PM, Chu Cheng Li wrote:
> Hi Everyone,
> I would like to start a discussion on KIP-1104:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1103%3A+Additional+metrics+for+cooperative+consumption
> <https://bitli.pro/2h2om_f8e74a0c>
> 
> This KIP allow foreign key extraction from both key and value in KTable
> Joins, before this KIP user can only extract foreign from record's value,
> this KIP provides more flexibility on it.
> 
> Regards,
> Peter Lee
> 

Re: [DISCUSS] KIP-1104: Allow Foreign Key Extraction from Both Key and Value in KTable Joins

[Chu Cheng Li <pe...@gmail.com>]

Thank you, Lucas and Matthias, for your feedback and thoughts.

I'll start the voting session for this KIP shortly.

Best regards,
Peter

On Wed, Nov 6, 2024 at 6:35 PM Lucas Brutschy
<lb...@confluent.io.invalid> wrote:

> Hey,
>
> this makes sense to me! Thank you for the KIP.
>
> I think the change is straightforward, and I think we can just vote
> this through. The only thing we could discuss is whether we want to
> keep the old overloads. I thought about it, but I think I agree that
> it's nicer to simplify the API a bit eventually, since the new
> overload is strictly more powerful than the old one. So no complaints
> at all, just writing down my thoughts.
>
> Cheers,
> Lucas
>
> On Tue, Nov 5, 2024 at 3:01 AM Matthias J. Sax <mj...@apache.org> wrote:
> >
> > Seems you did link to the wrong KIP. Should be
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1104%3A+Allow+Foreign+Key+Extraction+from+Both+Key+and+Value+in+KTable+Joins
> <https://bitli.pro/2hrKC_5e65c78f>
> >
> > :)
> >
> > Overall the KIP does make sense and I don't have any comments. Seems to
> > be quite clear.
> >
> >
> > -Matthias
> >
> > On 10/30/24 10:08 PM, Chu Cheng Li wrote:
> > > Hi Everyone,
> > > I would like to start a discussion on KIP-1104:
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1103%3A+Additional+metrics+for+cooperative+consumption
> <https://bitli.pro/2hrKD_200035b1>
> > > <https://bitli.pro/2h2om_f8e74a0c <https://bitli.pro/2hrKE_d7d53872>>
> > >
> > > This KIP allow foreign key extraction from both key and value in KTable
> > > Joins, before this KIP user can only extract foreign from record's
> value,
> > > this KIP provides more flexibility on it.
> > >
> > > Regards,
> > > Peter Lee
> > >
>

Re: [DISCUSS] KIP-1104: Allow Foreign Key Extraction from Both Key and Value in KTable Joins

[Lucas Brutschy <lb...@confluent.io.INVALID>]

Hey,

this makes sense to me! Thank you for the KIP.

I think the change is straightforward, and I think we can just vote
this through. The only thing we could discuss is whether we want to
keep the old overloads. I thought about it, but I think I agree that
it's nicer to simplify the API a bit eventually, since the new
overload is strictly more powerful than the old one. So no complaints
at all, just writing down my thoughts.

Cheers,
Lucas

On Tue, Nov 5, 2024 at 3:01 AM Matthias J. Sax <mj...@apache.org> wrote:
>
> Seems you did link to the wrong KIP. Should be
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1104%3A+Allow+Foreign+Key+Extraction+from+Both+Key+and+Value+in+KTable+Joins
>
> :)
>
> Overall the KIP does make sense and I don't have any comments. Seems to
> be quite clear.
>
>
> -Matthias
>
> On 10/30/24 10:08 PM, Chu Cheng Li wrote:
> > Hi Everyone,
> > I would like to start a discussion on KIP-1104:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1103%3A+Additional+metrics+for+cooperative+consumption
> > <https://bitli.pro/2h2om_f8e74a0c>
> >
> > This KIP allow foreign key extraction from both key and value in KTable
> > Joins, before this KIP user can only extract foreign from record's value,
> > this KIP provides more flexibility on it.
> >
> > Regards,
> > Peter Lee
> >