You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/12/31 01:07:37 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #4603:
[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
tqchen opened a new pull request #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603
Historically, we have classes like NodePtr/Ref/HashEqual.
After unified object protocol, these names are just alias of the object counterpart.
Moreover, there are helper macros defined over the places for defining these object.
This PR consoldiate the terminologies into the corresponding ones
in the Object system so we have a clean and consistent API moving forward.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] merrymercy removed a comment on issue #4603:
[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
merrymercy removed a comment on issue #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603#issuecomment-571532709
Do we also want to do renaming in python code? There are still NodeBase, register_node in python
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] wweic commented on a change in pull request #4603:
[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
wweic commented on a change in pull request #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603#discussion_r362144656
##########
File path: include/tvm/attrs.h
##########
@@ -85,7 +85,7 @@ namespace tvm {
*/
template<typename TNodeRef>
Review comment:
```suggestion
template<typename TObjectRef>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] merrymercy edited a comment on issue #4603:
[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
merrymercy edited a comment on issue #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603#issuecomment-571533087
@tqchen Do we also want to do renaming in python code? There are still NodeBase, register_node in python.
Given a lot of renaming has been done recently in several PRs. Could you also provide an all-in-one upgrade instruction for us to update our codebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] merrymercy edited a comment on issue #4603:
[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
merrymercy edited a comment on issue #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603#issuecomment-571533087
@tqchen Do we also want to do renaming in python code? There are still NodeBase, register_node in python.
Given a lot of renaming has been done recently in several PRs. Could you also provide a upgrade instructions for us to update our codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] merrymercy commented on issue #4603:
[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
merrymercy commented on issue #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603#issuecomment-571533087
@tqchen Do we also want to do renaming in python code? There are still NodeBase, register_node in python.
Given a lot of rename has been done recently in several PRs. Could you also provide a upgrade instructions for us to update our codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #4603:
[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603#issuecomment-569841465
cc @jroesch @wweic @yzhliu @Hzfengsy @ZihengJiang @junrushao1994 @merrymercy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #4603:
[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] merrymercy commented on issue #4603:
[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
merrymercy commented on issue #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603#issuecomment-571532709
Do we also want to do renaming in python code? There are still NodeBase, register_node in python
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4603: [REFACTOR][OBJECT]
Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603#issuecomment-569841465
cc @jroesch @wweic @yzhliu @Hzfengsy @ZihengJiang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #4603:
[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603#issuecomment-569841465
cc @jroesch @wweic @yzhliu @Hzfengsy @ZihengJiang @junrushao1994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4603: [REFACTOR][OBJECT]
Consoldiate NodePtr/Ref/Hash/Equal to Object
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4603: [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object
URL: https://github.com/apache/incubator-tvm/pull/4603#issuecomment-571787538
@merrymercy yes we should update the python side as well, please feel free to open PRs :)
Here is the guide #4647 , please feel free to add comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services