[jira] [Resolved] (HIVE-17284) remove OrcRecordUpdater.deleteEventIndexBuilder

["Eugene Koifman (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-17284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugene Koifman resolved HIVE-17284.
-----------------------------------
    Resolution: Won't Fix

hive.acid.key.index is actually need for delete event filtering HIVE-20738

> remove OrcRecordUpdater.deleteEventIndexBuilder
> -----------------------------------------------
>
>                 Key: HIVE-17284
>                 URL: https://issues.apache.org/jira/browse/HIVE-17284
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>            Priority: Minor
>
> There is no point in it. We know how many rows a delete_delta file has from ORC and they are all the same type - so no need for AcidStats.
>  hive.acid.key.index has no value since delete_delta files are never split and are not likely to have more than 1 stripe since they are very small.
> Also can remove KeyIndexBuilder.acidStats - we only have 1 type of event per file
>  
> if doing this, make sure to fix {{OrcInputFormat.isOriginal(Reader)}} and {{OrcInputFormat.isOriginal(Footer)}} etc
> there is new KeyIndexBuilder("delete") and new KeyIndexBuilder("insert").  The later is needed in HIVE-16812, the former can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)