You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/05 11:47:00 UTC

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #993: MINIFICPP-1478 Fix compilation errors of extensions

lordgamez opened a new pull request #993:
URL: https://github.com/apache/nifi-minifi-cpp/pull/993


   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #993: MINIFICPP-1478 Fix compilation errors of extensions

Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #993:
URL: https://github.com/apache/nifi-minifi-cpp/pull/993#discussion_r571082823



##########
File path: libminifi/test/bustache-tests/CMakeLists.txt
##########
@@ -33,7 +33,6 @@ FOREACH(testfile ${BUSTACHE_INTEGRATION_TESTS})
   createTests("${testfilename}")
   target_link_libraries(${testfilename} ${CATCH_MAIN_LIB})
   target_link_libraries(${testfilename} ${Boost_IOSTREAMS_LIBRARY})
-  target_link_libraries(${testfilename} bustache)

Review comment:
       I don't understand this change. Why do we no longer need this library?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #993: MINIFICPP-1478 Fix compilation errors of extensions

Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #993:
URL: https://github.com/apache/nifi-minifi-cpp/pull/993


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #993: MINIFICPP-1478 Fix compilation errors of extensions

Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #993:
URL: https://github.com/apache/nifi-minifi-cpp/pull/993#discussion_r571089642



##########
File path: libminifi/test/bustache-tests/CMakeLists.txt
##########
@@ -33,7 +33,6 @@ FOREACH(testfile ${BUSTACHE_INTEGRATION_TESTS})
   createTests("${testfilename}")
   target_link_libraries(${testfilename} ${CATCH_MAIN_LIB})
   target_link_libraries(${testfilename} ${Boost_IOSTREAMS_LIBRARY})
-  target_link_libraries(${testfilename} bustache)

Review comment:
       We never needed this actually. We add minifi-bustache-extensions library as a whole archive which links the locally built BUSTACHE::libbustache bundled library. This line would additionally try to link the bustache library installed on the system.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org