[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11704: feat(templating): Safer Jinja template processing

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #11704:
URL: https://github.com/apache/incubator-superset/pull/11704#discussion_r523579832



##########
File path: superset/jinja_context.py
##########
@@ -186,6 +188,28 @@ def url_param(
         return result
 
 
+def safe_proxy(func: Callable[..., Any], *args: Any, **kwargs: Any) -> Any:
+    none_type = type(None).__name__
+    allowed_types = [

Review comment:
       probably better to declare as `ALLOWED_TYPES` in module scope as it will never change




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org