[GitHub] dangogh commented on a change in pull request #2852: TO GO: Invalid password validation with tests

[GitBox <gi...@apache.org>]

dangogh commented on a change in pull request #2852: TO GO: Invalid password validation with tests
URL: https://github.com/apache/trafficcontrol/pull/2852#discussion_r219567249
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/auth/authenticate_test.go
 ##########
 @@ -50,3 +51,21 @@ func TestScryptPasswordIsRequired(t *testing.T) {
 		t.Errorf("scrypt password should be required")
 	}
 }
+
+func TestPasswordStrength(t *testing.T) {
+
+	passwords := []string{"password", "pa$$word"}
 
 Review comment:
   how about testing for empty password or password that's too short?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services