You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/08 14:41:23 UTC

[GitHub] [dubbo-go] wenxuwan opened a new pull request #855: Remove unmeaning logic

wenxuwan opened a new pull request #855:
URL: https://github.com/apache/dubbo-go/pull/855


   **What this PR does**:
   
   Remove the unmeaning variables in RegistryDataListener and change unlock to defer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] codecov-io commented on pull request #855: Remove unmeaning logic

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #855:
URL: https://github.com/apache/dubbo-go/pull/855#issuecomment-727104165


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/855?src=pr&el=h1) Report
   > Merging [#855](https://codecov.io/gh/apache/dubbo-go/pull/855?src=pr&el=desc) (1942615) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e11faed28e4d6c036b5c55bc65c8d7b42af4f0ec?el=desc) (e11faed) will **increase** coverage by `0.12%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/855/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/855?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #855      +/-   ##
   ===========================================
   + Coverage    59.91%   60.03%   +0.12%     
   ===========================================
     Files          260      260              
     Lines        12807    12810       +3     
   ===========================================
   + Hits          7673     7691      +18     
   + Misses        4177     4162      -15     
     Partials       957      957              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/855?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/855/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `51.11% <0.00%> (-0.77%)` | :arrow_down: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/855/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `67.16% <100.00%> (+0.49%)` | :arrow_up: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/855/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/855/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `69.60% <0.00%> (+0.88%)` | :arrow_up: |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/855/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
   | [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/855/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `51.42% <0.00%> (+5.30%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/855?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/855?src=pr&el=footer). Last update [e11faed...85544c7](https://codecov.io/gh/apache/dubbo-go/pull/855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] wenxuwan commented on pull request #855: Remove unmeaning logic

Posted by GitBox <gi...@apache.org>.
wenxuwan commented on pull request #855:
URL: https://github.com/apache/dubbo-go/pull/855#issuecomment-726570805


   > Make `checks` pass pls
   
   done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] wenxuwan commented on a change in pull request #855: Remove unmeaning logic

Posted by GitBox <gi...@apache.org>.
wenxuwan commented on a change in pull request #855:
URL: https://github.com/apache/dubbo-go/pull/855#discussion_r522599442



##########
File path: registry/zookeeper/registry.go
##########
@@ -290,20 +290,17 @@ func (r *zkRegistry) getCloseListener(conf *common.URL) (*RegistryConfigurationL
 
 	var zkListener *RegistryConfigurationListener
 	r.dataListener.mutex.Lock()
+	defer r.dataListener.mutex.Unlock()

Review comment:
       No.....getListener use  defer too, so here may be cause dead lock.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] AlexStocks commented on pull request #855: Remove unmeaning logic

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #855:
URL: https://github.com/apache/dubbo-go/pull/855#issuecomment-724441768


   wait for @CodingSinger's comment


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] zouyx merged pull request #855: Remove unmeaning logic

Posted by GitBox <gi...@apache.org>.
zouyx merged pull request #855:
URL: https://github.com/apache/dubbo-go/pull/855


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] zouyx commented on a change in pull request #855: Remove unmeaning logic

Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #855:
URL: https://github.com/apache/dubbo-go/pull/855#discussion_r519914066



##########
File path: registry/zookeeper/registry.go
##########
@@ -290,20 +290,17 @@ func (r *zkRegistry) getCloseListener(conf *common.URL) (*RegistryConfigurationL
 
 	var zkListener *RegistryConfigurationListener
 	r.dataListener.mutex.Lock()
+	defer r.dataListener.mutex.Unlock()

Review comment:
       If this lock use defer, will include [listenerLock](https://github.com/apache/dubbo-go/blob/234633932aab82913ede37c3f32c7a48a912b869/registry/zookeeper/registry.go#L309), is it right logic?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] CodingSinger commented on pull request #855: Remove unmeaning logic

Posted by GitBox <gi...@apache.org>.
CodingSinger commented on pull request #855:
URL: https://github.com/apache/dubbo-go/pull/855#issuecomment-724527553


   > wait for @CodingSinger's comment
   
   看了下之前的pr,这里应该是忘了写了,应该在close以及替换的时候设置close为true


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org