[GitHub] [geode] kirklund commented on a change in pull request #6863: GEODE-9595: Exclude circular build dependencies

[GitBox <gi...@apache.org>]

kirklund commented on a change in pull request #6863:
URL: https://github.com/apache/geode/pull/6863#discussion_r707777157



##########
File path: geode-core/build.gradle
##########
@@ -233,7 +233,9 @@ dependencies {
         exclude group: '*'
     }
 
-    runtimeOnly(project(':geode-deployment:geode-deployment-legacy'))
+    runtimeOnly(project(':geode-deployment:geode-deployment-legacy')) {
+        exclude module: 'geode-core'

Review comment:
       You should be pairing with Dale and me then :) This was hard to debug.
   
   I'm trying to back GEODE-9486. AnalyzeSerializables integration tests load the `sanctioned-geode-*-serializables.txt` resource and then generates a failure message to point the person running the test to overwrite the `sanctioned-geode-*-serializables.txt` with the generated actual serializables file. However, the error message was broken. After fixing it, it fails only in the modules that have these circular dependencies. We discovered that when the test runs (only in modules with circular dependencies) the classes and resources are loaded from the geode-*module*/build/libs/geode-*module*.jar which causes the failure message to blow up.
   
   How about we pair from 10am to noon tomorrow?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org