You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 16:56:43 UTC

[GitHub] [arrow] lwhite1 commented on pull request #13589: ARROW-17004: [Java] Add utility to bind Arrow data to JDBC parameters

lwhite1 commented on PR #13589:
URL: https://github.com/apache/arrow/pull/13589#issuecomment-1184674323

   Overall, this looks really nice to me. 
   
   One minor nit (not from the current change set): The statement on line 87 "Currently, it is not possible to define a custom type conversion for a supported or unsupported type."  has me scratching my head a bit  Should it just say "it is not possible to define a custom type conversion"?  If there's a quick re-phrasing that helps, it might be worth adding.  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org