[GitHub] [apisix] soulbird commented on a change in pull request #6562: feat: allow set timeout for proxy-mirror

[GitBox <gi...@apache.org>]

soulbird commented on a change in pull request #6562:
URL: https://github.com/apache/apisix/pull/6562#discussion_r824326754



##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -765,6 +765,18 @@ http {
             }
             {% end %}
 
+
+            {% if proxy_mirror_timeouts then %}
+                {% if proxy_mirror_timeouts.connect then %}
+            proxy_connect_timeout {* proxy_mirror_timeouts.connect *};
+                {% end %}
+                {% if proxy_mirror_timeouts.read then %}
+            proxy_read_timeout {* proxy_mirror_timeouts.read *};
+                {% end %}
+                {% if proxy_mirror_timeouts.send then %}
+            proxy_send_timeout {* proxy_mirror_timeouts.send *};
+                {% end %}
+            {% end %}

Review comment:
       These directives apply to all plugins, I don't think it's appropriate for you to do this. Maybe you can implement this functionality in your own plugin by `before_proxy`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org