[jira] [Commented] (CB-8635) InAppBrowser on Windows adds 40px gray border, wrapper div without class or id

["John Little (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360615#comment-14360615 ] 

John Little commented on CB-8635:
---------------------------------

Hi,

I am currently editing the file InAppBrowserProxy.js in the plugins\org.apache.cordova.inappbrowser\src\windows (inside my product directory)
and changing lines 115-116 to remove the 40px border width so
  browserWrap.style.borderWidth = "40px";
  browserWrap.style.width = "calc(100% - 80px)";
  browserWrap.style.height = "calc(100% - 80px)";
becomes
  browserWrap.style.borderWidth = "00px";
  browserWrap.style.width = "calc(100% - 00px)";
  browserWrap.style.height = "calc(100% - 00px)";

This is fine as a temporary solution but it would be great to have a fix.

> InAppBrowser on Windows adds 40px gray border, wrapper div without class or id
> ------------------------------------------------------------------------------
>
>                 Key: CB-8635
>                 URL: https://issues.apache.org/jira/browse/CB-8635
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin InAppBrowser
>    Affects Versions: 3.6.0
>         Environment: Windows 8.1, Windows Phone 8.1
>            Reporter: Brandon Paddock
>
> The InAppBrowserProxy on Windows 8.1 does some weird things. One of them is that it adds a wrapper div with a bunch of inline styles on it, including a gray 40px border on all sides. This appears even if you set the "location=no" option to disable the default browser controls.
> Because this div is inserted directly under the body element with no id or class, you can't override its styling via CSS (and since it uses inline styles, you'd have to use !important to override them).
> Suggested fixes:
> 1) Assign a class name to the div so it can be styled.
> 2) Don't use an inline style for the default styling. Use CSS.
> 3) Don't put this weird gray border in the default styling (it isn't there on Android so why put it there on Windows?)
> 4) Or, remove the div entirely (at least in the location=no case).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org