You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2024/03/04 20:33:52 UTC

(superset) branch test-ci updated (eb5cc35d46 -> 03b28ff2aa)

This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a change to branch test-ci
in repository https://gitbox.apache.org/repos/asf/superset.git


 discard eb5cc35d46 chore: test
    omit be144aad87 build(deps): bump yargs and @types/yargs in /superset-frontend (#26870)
    omit 87558ed065 chore(dependencies): bump less from 3.12.2 to 4.2.0 in /superset-frontend (#26841)
    omit 5392a8c50f chore(actions): run docs actions on Node 16 to conform with the project (#26868)
    omit 785e832e8d chore(actions): generate FOSSA report on master, and ALWAYS check for… (#26857)
    omit 29bc68bd3e feat(i18n): add ukranian translations (#25323)
    omit 5d8b7bb6a5 build(deps-dev): bump @types/uuid from 9.0.7 to 9.0.8 in /superset-websocket (#26826)
    omit 0695173a81 build(deps): bump @testing-library/react-hooks from 5.0.3 to 5.1.3 in /superset-frontend (#26867)
    omit 911c6e53c2 build(deps): bump mousetrap and @types/mousetrap in /superset-frontend (#26866)
    omit 1029b7dadc build(deps): bump react-redux from 7.2.8 to 7.2.9 in /superset-frontend (#26865)
    omit 806e4c4b3f chore(dependabot): lowering bump cadence from weekly to monthly (#26855)
    omit 84c48d11d8 fix: Bar charts horizontal margin adjustment error (#26817)
    omit 8db5d13749 chore(CI): get docs building on ALL branches. (#26854)
    omit c3aacc6f42 build(deps-dev): bump @types/node from 20.11.5 to 20.11.10 in /superset-websocket (#26825)
    omit 71a950fc80 fix(chart table in dashboard): improve screen reading of table (#26453)
    omit be7c9490a1 chore(lint/a11y): fixing and locking down jsx-a11y/anchor-is-valid (#26820)
    omit 78dc6ce6c9 feat: add chart id and dataset id to global logs (#26443)
    omit fade4806ce fix: prevent guest user from modifying metrics (#26749)
    omit 881268a8da chore(dependencies): bumps match-sorter (#26819)
    omit 6c029ce2e8 chore: Add permission to view and drill on Dashboard context (#26798)
    omit b0c8f620d6 build(deps): bump use-immer from 0.8.1 to 0.9.0 in /superset-frontend (#26827)
    omit 29582e8d86 chore(deps): bump typescript to 4.8.4 (#24272)
    omit f73760a5d1 build(deps): bump @types/react-table from 7.0.29 to 7.7.19 in /superset-frontend (#26832)
    omit eea71eb6bc build(deps-dev): bump @docusaurus/module-type-aliases from 3.1.0 to 3.1.1 in /docs (#26834)
    omit 9ece4049f1 build(deps-dev): bump webpack from 5.89.0 to 5.90.0 in /docs (#26839)
    omit 8ca541c850 chore: Slovenian translation update (#23873)
    omit 64ba5797df fix(deck.gl Multiple Layer Chart): Add Contour and Heatmap Layer as options (#25923)
    omit dfc614bdc3 chore: fix GitHub 'Unchanged files with check annotations' reports in PR (#26702)
    omit a6290702d2 build(deps): bump prism-react-renderer from 1.2.1 to 2.3.1 in /docs (#26726)
    omit e9c2fdf8ac chore(ci): change code owners for .github (#26813)
    omit 6bc85a0d2c chore(dependencies): bumping jinja2 (#26794)
    omit 1f6c270f15 fix(time-series table): Can't compare from the beginning of the time range (#26814)
    omit c657745f02 chore: add google-auth for new example dashboard (#26816)
    omit 092129201e chore: Reformat changelogs (#26815)
    omit 4f56f5ee84 fix(tags): Filter system tags from the tags list (#26701)
    omit f084572dc7 chore(dependencies): bumping fonttools (#26793)
    omit 3dcfbcc3a5 chore: Technical Debt Metrics (#26442)
    omit 5e633d2bb0 fix: Row limit hardcoded (#26807)
    omit 23460b21f6 chore: Splits the CHANGELOG into multiple files (#26800)
    omit 8657fa753b build(deps): update jquery requirement from ^3.4.1 to ^3.7.1 in /superset-frontend/packages/superset-ui-demo (#26621)
    omit ed934a93e1 feat: Stop editor scrolling to top (#26754)
    omit 11f0dd91db chore(RESOURCES): fix markdown for table formatting (#26789)
    omit 845bcc9bea fix: docker should always run, even in forks (#26801)
    omit 424b4c2378 chore: Add Embed Modal extension override and tests (#26759)
    omit 8f8e7c2aa6 fix: add user to latest-release-tag workflow (#26752)
    omit 01fdfbee09 fix(logging): Filter out undefined columns (#26314)
    omit 11a60c92ea build(deps-dev): bump css-minimizer-webpack-plugin from 3.4.1 to 6.0.0 in /superset-frontend (#26656)
    omit 2bb0b46b55 fix: helm chart comment on SECRET_KEY (#26674)
    omit 73c6abde5e fix(docker): credentials issues around superset-cache in forks (#26772)
    omit 0f590799b2 chore: improve/decouple eslint and tsc 'npm run' commands (#26704)
     new 03b28ff2aa chore: test

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (eb5cc35d46)
            \
             N -- N -- N   refs/heads/test-ci (03b28ff2aa)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .github/CODEOWNERS                                 |     8 +-
 .github/dependabot.yml                             |    70 +-
 .github/workflows/docker.yml                       |    21 +-
 .github/workflows/generate-FOSSA-report.yml        |    63 -
 .github/workflows/latest-release-tag.yml           |     5 -
 .github/workflows/license-check.yml                |    47 +-
 .github/workflows/superset-docs-verify.yml         |    33 -
 ...{superset-docs-deploy.yml => superset-docs.yml} |    22 +-
 .github/workflows/superset-frontend.yml            |    13 +-
 .github/workflows/superset-websocket.yml           |     7 +-
 .github/workflows/tech-debt.yml                    |    31 -
 .rat-excludes                                      |     8 +-
 CHANGELOG.md                                       |  4124 ++++-
 CHANGELOG/1.4.1.md                                 |    40 -
 CHANGELOG/1.4.2.md                                 |    32 -
 CHANGELOG/1.5.0.md                                 |   860 --
 CHANGELOG/1.5.1.md                                 |    36 -
 CHANGELOG/1.5.2.md                                 |    48 -
 CHANGELOG/1.5.3.md                                 |    46 -
 CHANGELOG/2.0.0.md                                 |   514 -
 CHANGELOG/2.0.1.md                                 |    82 -
 CHANGELOG/2.1.0.md                                 |  1197 --
 CHANGELOG/2.1.1.md                                 |    67 -
 CHANGELOG/2.1.2.md                                 |    41 -
 CHANGELOG/2.1.3.md                                 |    40 -
 CHANGELOG/3.0.0.md                                 |   792 -
 CHANGELOG/3.0.1.md                                 |    65 -
 CHANGELOG/3.0.2.md                                 |    73 -
 CHANGELOG/3.0.3.md                                 |    80 -
 CHANGELOG/3.1.0.md                                 |   417 -
 CONTRIBUTING.md                                    |     9 +-
 RELEASING/README.md                                |    27 +-
 RELEASING/email_templates/announce.j2              |    10 +-
 RELEASING/email_templates/result_pmc.j2            |     4 +-
 RELEASING/email_templates/vote_pmc.j2              |     8 +-
 RELEASING/release-notes-1-4/README.md              |     5 +-
 RELEASING/release-notes-1-5/README.md              |     2 +-
 RELEASING/verify_release.py                        |    18 -
 RESOURCES/STANDARD_ROLES.md                        |   439 +-
 docker/docker-entrypoint-initdb.d/examples-init.sh |    19 -
 dockerize.Dockerfile                               |    17 -
 docs/README.md                                     |     1 +
 docs/docs/contributing/hooks-and-linting.mdx       |     5 +-
 docs/docusaurus.config.js                          |     4 +-
 docs/package.json                                  |     6 +-
 docs/src/components/SectionHeader.tsx              |     2 +-
 docs/src/pages/community.tsx                       |     1 +
 docs/static/img/calendar-icon.svg                  |    18 -
 docs/static/img/check-icon.svg                     |    18 -
 docs/static/img/databases/apache-pinot.svg         |    18 -
 docs/static/img/databases/csv.svg                  |    18 -
 docs/yarn.lock                                     |   114 +-
 helm/superset/Chart.yaml                           |     2 +-
 helm/superset/README.md                            |     2 +-
 helm/superset/values.yaml                          |     4 +-
 requirements/base.txt                              |    34 +-
 requirements/development.txt                       |    19 +-
 requirements/integration.txt                       |     8 +-
 requirements/testing.txt                           |    14 +-
 scripts/docker_build_push.sh                       |    11 +-
 .../.gitignore => scripts/gen_changelog.sh         |    12 +-
 scripts/tag_latest_release.sh                      |    28 +-
 setup.py                                           |     6 +-
 superset-frontend/.eslintrc.js                     |    11 +-
 superset-frontend/.prettierignore                  |     2 +-
 superset-frontend/cypress-base/.eslintrc           |     7 +-
 .../cypress/e2e/dashboard/drillby.test.ts          |     1 -
 .../cypress/e2e/dashboard/editmode.test.ts         |     1 -
 .../cypress-base/cypress/support/e2e.ts            |     2 -
 .../cypress-base/cypress/utils/index.ts            |    29 +-
 .../cypress-base/cypress/utils/vizPlugins.ts       |     1 -
 superset-frontend/cypress-base/tsconfig.json       |     3 +-
 superset-frontend/js_build.sh                      |     3 +-
 superset-frontend/package-lock.json                |  4842 +++---
 superset-frontend/package.json                     |    33 +-
 .../superset-ui-chart-controls/CHANGELOG.md        |     3 +-
 .../src/shared-controls/sharedControls.tsx         |     4 +-
 .../packages/superset-ui-core/package.json         |     2 +-
 .../src/chart/components/createLoadableRenderer.ts |     7 +-
 .../superset-ui-core/src/query/api/v1/makeApi.ts   |     6 +-
 .../superset-ui-core/src/ui-overrides/types.ts     |    10 -
 .../packages/superset-ui-core/src/utils/html.tsx   |    18 -
 .../src/validator/validateMaxValue.ts              |    18 -
 .../packages/superset-ui-demo/CHANGELOG.md         |    12 +
 .../packages/superset-ui-demo/package.json         |     2 +-
 .../superset-ui-switchboard/src/switchboard.ts     |     5 +-
 .../legacy-plugin-chart-calendar/CHANGELOG.md      |     4 +
 .../plugins/legacy-plugin-chart-chord/CHANGELOG.md |     4 +
 .../legacy-plugin-chart-country-map/CHANGELOG.md   |     4 +
 .../legacy-plugin-chart-event-flow/CHANGELOG.md    |     4 +
 .../legacy-plugin-chart-heatmap/CHANGELOG.md       |     4 +
 .../legacy-plugin-chart-histogram/CHANGELOG.md     |     4 +
 .../legacy-plugin-chart-horizon/CHANGELOG.md       |     4 +
 .../legacy-plugin-chart-map-box/CHANGELOG.md       |     4 +
 .../legacy-plugin-chart-paired-t-test/CHANGELOG.md |     4 +
 .../CHANGELOG.md                                   |     4 +
 .../legacy-plugin-chart-partition/CHANGELOG.md     |     4 +
 .../plugins/legacy-plugin-chart-rose/CHANGELOG.md  |     4 +
 .../legacy-plugin-chart-sankey/CHANGELOG.md        |     4 +
 .../legacy-plugin-chart-world-map/CHANGELOG.md     |     4 +
 .../legacy-preset-chart-deckgl/package.json        |     2 +-
 .../legacy-preset-chart-deckgl/src/index.ts        |     2 -
 .../src/layers/Arc/Arc.tsx                         |     8 +-
 .../src/layers/Geojson/Geojson.tsx                 |     4 +-
 .../src/layers/Heatmap/Heatmap.tsx                 |     2 +-
 .../src/layers/Path/Path.tsx                       |     2 +-
 .../src/layers/Polygon/Polygon.tsx                 |    10 +-
 .../src/layers/Scatter/Scatter.tsx                 |    10 +-
 .../src/layers/Screengrid/Screengrid.tsx           |     4 +-
 .../legacy-preset-chart-deckgl/src/layers/index.ts |     4 -
 .../plugins/legacy-preset-chart-nvd3/CHANGELOG.md  |    12 +
 .../plugins/plugin-chart-echarts/CHANGELOG.md      |    13 +-
 .../src/BigNumber/CHANGELOG.md                     |    11 +-
 .../src/Timeseries/transformProps.ts               |     1 -
 .../src/Timeseries/transformers.ts                 |    42 +-
 .../plugin-chart-echarts/src/utils/series.ts       |    14 -
 .../plugin-chart-echarts/test/utils/series.test.ts |    32 -
 .../plugins/plugin-chart-pivot-table/CHANGELOG.md  |     7 +-
 .../plugins/plugin-chart-table/CHANGELOG.md        |     4 +
 .../plugins/plugin-chart-table/package.json        |     4 +-
 .../plugin-chart-table/src/DataTable/DataTable.tsx |     1 -
 .../src/DataTable/hooks/useSticky.tsx              |    22 +-
 .../plugins/plugin-chart-table/src/Styles.tsx      |     7 +-
 .../plugin-chart-table/src/controlPanel.tsx        |     4 +-
 .../plugins/plugin-chart-table/src/utils/extent.ts |     9 +-
 .../plugins/plugin-chart-word-cloud/CHANGELOG.md   |     4 +
 .../src/chart/WordCloud.tsx                        |     2 -
 superset-frontend/scripts/build.js                 |     2 +-
 .../scripts/eslint-metrics-uploader.js             |   144 -
 superset-frontend/src/SqlLab/actions/sqlLab.js     |     6 -
 .../AceEditorWrapper/AceEditorWrapper.test.tsx     |     1 -
 .../SqlLab/components/AceEditorWrapper/index.tsx   |    15 +-
 .../SqlLab/components/QueryLimitSelect/index.tsx   |     2 +-
 .../src/SqlLab/components/SqlEditor/index.tsx      |    12 +-
 .../src/SqlLab/reducers/getInitialState.ts         |     1 -
 superset-frontend/src/SqlLab/reducers/sqlLab.js    |    12 -
 superset-frontend/src/SqlLab/types.ts              |     6 -
 .../src/components/AuditInfo/ModifiedInfo.test.tsx |    18 -
 .../src/components/AuditInfo/index.tsx             |    18 -
 .../Chart/ChartContextMenu/ChartContextMenu.tsx    |    12 +-
 .../Chart/ChartContextMenu/useContextMenu.test.tsx |    36 +-
 .../components/Chart/DrillBy/DrillByModal.test.tsx |    36 +-
 .../src/components/Chart/DrillBy/DrillByModal.tsx  |    17 +-
 .../Chart/DrillDetail/DrillDetailModal.test.tsx    |    26 +-
 .../Chart/DrillDetail/DrillDetailModal.tsx         |    63 +-
 superset-frontend/src/components/Modal/Modal.tsx   |     1 -
 .../src/components/Tags/utils.test.tsx             |    18 -
 .../index.tsx => DashboardEmbedControls.tsx}       |    13 +-
 .../EmbeddedModal/EmbeddedModal.test.tsx           |   172 -
 .../src/dashboard/components/Header/index.jsx      |     2 +-
 .../SliceHeaderControls.test.tsx                   |    53 +-
 .../components/SliceHeaderControls/index.tsx       |    32 +-
 .../dashboard/components/gridComponents/Chart.jsx  |     4 +-
 .../DownloadMenuItems/DownloadAsImage.test.tsx     |    18 -
 .../menu/DownloadMenuItems/DownloadAsImage.tsx     |    18 -
 .../menu/DownloadMenuItems/DownloadAsPdf.test.tsx  |    18 -
 .../menu/DownloadMenuItems/DownloadAsPdf.tsx       |    18 -
 .../DownloadMenuItems/DownloadMenuItems.test.tsx   |    18 -
 .../components/controls/ContourControl/types.ts    |    18 -
 .../components/controls/CurrencyControl/index.ts   |    18 -
 .../TimeSeriesColumnControl.test.tsx               |    13 -
 .../controls/TimeSeriesColumnControl/index.jsx     |     4 +-
 superset-frontend/src/pages/Tags/index.tsx         |    20 +-
 superset-frontend/src/types/dom-to-pdf.d.ts        |    18 -
 .../src/visualizations/TimeTable/TimeTable.jsx     |     6 +-
 superset-websocket/package-lock.json               |    28 +-
 superset-websocket/package.json                    |     7 +-
 superset/charts/data/api.py                        |    21 +-
 superset/commands/dashboard/importers/v0.py        |     2 +-
 superset/common/query_object.py                    |     2 +-
 superset/config.py                                 |     1 -
 superset/db_engine_specs/README.md                 |    19 -
 superset/db_engine_specs/databend.py               |    10 -
 superset/migrations/shared/constraints.py          |    16 -
 superset/migrations/shared/native_filters.py       |    16 -
 superset/security/manager.py                       |    27 +-
 superset/tags/api.py                               |     3 -
 superset/tags/filters.py                           |    39 -
 superset/translations/sl/LC_MESSAGES/messages.json |  2340 +--
 superset/translations/sl/LC_MESSAGES/messages.po   | 14854 ++++++++++---------
 superset/translations/uk/LC_MESSAGES/messages.json |  6419 --------
 superset/translations/uk/LC_MESSAGES/messages.po   | 12162 ---------------
 superset/views/core.py                             |     1 +
 tests/integration_tests/celery_tests.py            |     2 +-
 tests/integration_tests/charts/data/api_tests.py   |    53 +-
 .../security/guest_token_security_tests.py         |    15 -
 tests/integration_tests/security_tests.py          |     2 -
 tests/integration_tests/superset_test_config.py    |     2 +-
 tests/integration_tests/tags/api_tests.py          |    46 -
 tests/unit_tests/forms_tests.py                    |    16 -
 tests/unit_tests/scripts/docker_build_push_test.py |    16 -
 .../unit_tests/scripts/tag_latest_release_test.py  |    16 -
 tests/unit_tests/security/manager_test.py          |    76 -
 tests/unit_tests/tags/__init__.py                  |    16 -
 tests/unit_tests/tags/commands/create_test.py      |    16 -
 tests/unit_tests/tags/commands/update_test.py      |    16 -
 tests/unit_tests/tasks/test_async_queries.py       |    16 -
 197 files changed, 15261 insertions(+), 37023 deletions(-)
 delete mode 100644 .github/workflows/generate-FOSSA-report.yml
 delete mode 100644 .github/workflows/superset-docs-verify.yml
 rename .github/workflows/{superset-docs-deploy.yml => superset-docs.yml} (78%)
 delete mode 100644 .github/workflows/tech-debt.yml
 delete mode 100644 CHANGELOG/1.4.1.md
 delete mode 100644 CHANGELOG/1.4.2.md
 delete mode 100644 CHANGELOG/1.5.0.md
 delete mode 100644 CHANGELOG/1.5.1.md
 delete mode 100644 CHANGELOG/1.5.2.md
 delete mode 100644 CHANGELOG/1.5.3.md
 delete mode 100644 CHANGELOG/2.0.0.md
 delete mode 100644 CHANGELOG/2.0.1.md
 delete mode 100644 CHANGELOG/2.1.0.md
 delete mode 100644 CHANGELOG/2.1.1.md
 delete mode 100644 CHANGELOG/2.1.2.md
 delete mode 100644 CHANGELOG/2.1.3.md
 delete mode 100644 CHANGELOG/3.0.0.md
 delete mode 100644 CHANGELOG/3.0.1.md
 delete mode 100644 CHANGELOG/3.0.2.md
 delete mode 100644 CHANGELOG/3.0.3.md
 delete mode 100644 CHANGELOG/3.1.0.md
 copy docker/pythonpath_dev/.gitignore => scripts/gen_changelog.sh (72%)
 mode change 100644 => 100755
 delete mode 100644 superset-frontend/scripts/eslint-metrics-uploader.js
 rename superset-frontend/src/dashboard/components/{EmbeddedModal/index.tsx => DashboardEmbedControls.tsx} (94%)
 delete mode 100644 superset-frontend/src/dashboard/components/EmbeddedModal/EmbeddedModal.test.tsx
 delete mode 100644 superset/tags/filters.py
 delete mode 100644 superset/translations/uk/LC_MESSAGES/messages.json
 delete mode 100644 superset/translations/uk/LC_MESSAGES/messages.po


(superset) 01/01: chore: test

Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch test-ci
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 03b28ff2aa35f2cd9d22237e1277adb30a9cb153
Author: Michael S. Molina <mi...@gmail.com>
AuthorDate: Mon Mar 4 15:33:39 2024 -0500

    chore: test
---
 CONTRIBUTING.md | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index de40865edc..85e50d8f04 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -41,7 +41,7 @@ little bit helps, and credit will always be given.
       - [Reviewing](#reviewing)
       - [Test Environments](#test-environments)
       - [Merging](#merging)
-      - [Post-merge Responsibility](#post-merge-responsibility)
+      - [Post-merge Reswponsibility](#post-merge-responsibility)
   - [Design Guidelines](#design-guidelines)
     - [Capitalization guidelines](#capitalization-guidelines)
       - [Sentence case](#sentence-case)
@@ -217,7 +217,7 @@ Security team members must:
 - Have an [ICLA](https://www.apache.org/licenses/contributor-agreements.html) signed with Apache Software Foundation.
 - Not reveal information about pending and unfixed security issues to anyone (including their employers) unless specifically authorised by the security team members, e.g., if the security team agrees that diagnosing and solving an issue requires the involvement of external experts.
 
-A release manager, the contributor overseeing the release of a specific version of Apache Superset, is by default a member of the security team.  However, they are not expected to be active in assessing, discussing, and fixing security issues.
+A release manager, the contributor overseeing the release of a specific version of Apache Superset, is by default a member of the security team. However, they are not expected to be active in assessing, discussing, and fixing security issues.
 
 Security team members should also follow these general expectations:
 
@@ -374,8 +374,8 @@ Triaging goals
 
 First, add **Category labels (a.k.a. hash labels)**. Every issue/PR must have one hash label (except spam entry). Labels that begin with `#` defines issue/PR type:
 
-| Label           | for Issue                                                                                                               | for PR                                                                                                                                            |
-| --------------- | ----------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------- |
+| Label           | for Issue                                                                                                               | for PR                                                                                                                            |
+| --------------- | ----------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------- |
 | `#bug`          | Bug report                                                                                                              | Bug fix                                                                                                                           |
 | `#code-quality` | Describe problem with code, architecture or productivity                                                                | Refactor, tests, tooling                                                                                                          |
 | `#feature`      | New feature request                                                                                                     | New feature implementation                                                                                                        |
@@ -648,22 +648,28 @@ If while using the above commands you encounter an error related to the limit of
 ```bash
 Error: ENOSPC: System limit for number of file watchers reached
 ```
+
 The error is thrown because the number of files monitored by the system has reached the limit.
 You can address this this error by increasing the number of inotify watchers.
 
 The current value of max watches can be checked with:
+
 ```bash
 cat /proc/sys/fs/inotify/max_user_watches
 ```
+
 Edit the file /etc/sysctl.conf to increase this value.
 The value needs to be decided based on the system memory [(see this StackOverflow answer for more context)](https://stackoverflow.com/questions/535768/what-is-a-reasonable-amount-of-inotify-watches-with-linux).
 
 Open the file in editor and add a line at the bottom specifying the max watches values.
+
 ```bash
 fs.inotify.max_user_watches=524288
 ```
+
 Save the file and exit editor.
 To confirm that the change succeeded, run the following command to load the updated value of max_user_watches from sysctl.conf:
+
 ```bash
 sudo sysctl -p
 ```