[PR] fix(consumer): keep an unknown total lag from being replaced by a partial subtotal [rocketmq-dashboard]

["123123213weqw (via GitHub)" <gi...@apache.org>]

123123213weqw opened a new pull request, #7053:
URL: https://github.com/apache/rocketmq-dashboard/pull/7053

   Fixes #6423.
   
   Consumer health diagnostics substituted a partial queue subtotal for an unknown total: when `group.totalLag` was unknown (-1), `reportedLag()` unconditionally returned the sum of available queue lags — a partial subtotal ([17, -1] → 17) was presented as the total, and an all-unknown observation became a reported 0.
   
   The subtotal is now used only when every queue's lag is available (non-empty and fully known); otherwise `reportedLag` stays `null` and the page renders it as unavailable. A measured total — including a measured zero — still always wins, and an observed positive subtotal still triggers `NO_ACTIVE_CLIENTS_WITH_LAG` even when the reported total is unavailable, so warning behavior is unchanged in every previously-correct case.
   
   Red-first: five regression tests (partial-unknown → `reportedLag: null` with the subtotal kept; all-known fallback; measured zero preserved; no observations → null; positive subtotal still fires the warning) fail on the old code, and one existing assertion that had baked in the buggy `reportedLag: 0` is corrected. Diagnostics + ConsumerPage + race suites: 66/66.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(consumer): keep an unknown total lag from being replaced by a partial subtotal [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins merged PR #7053:
URL: https://github.com/apache/rocketmq-dashboard/pull/7053


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org