You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by Dave <sn...@gmail.com> on 2017/10/01 14:47:40 UTC

[VOTE] Release rc-3 as Roller 5.2.0

I've prepared a third release candidate for Roller 5.2.0. This release is
primarily a bug fix release, with lots of fixes from Kohei. I have created
a release candidate which you can find here:

    https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-3/

And the list of issues resolved is here:


https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310906&version=12340980

Thanks to Greg for finding some issues in rc-2. I believe I have fixed all
the problems that he found plus a couple more. Here's what has changed
since rc-2:

   1. roller.log location now default to the Catalina Base logs directory
   2. Added cache "clear" to list of allowed Struts DMI methods
   3. Use namespace not name in struts.xml Chained Actions
   4. Use "var" instead of "id" for some s:iterator tags
   5. Now shows Media File URL correctly in Media File View modal

I'm currently running this code on rollerweblogger.org and it seems to be
working well.

Please take a look and vote.

Thanks,
Dave

Re: [VOTE] Release rc-3 as Roller 5.2.0

Posted by Dave <sn...@gmail.com>.
Greg and Kohei: thanks so much for helping out and giving good feedback.
This is great!
I hope to work through most or all of these issues today.

I'm working in the roller-5.2.0 branch.

Dave


On Sun, Oct 8, 2017 at 4:14 AM Greg Huber <gr...@gmail.com> wrote:

> Dave,
>
> Looks ok, but found some new items.
>
> ######
>
> Needs some more allowed methods.
>
>  eg createNewDirectory for the meda files create action.  btw, rather than
> creating global-allowed-methods you can add them to the action itself in a
> <allowed-methods> :
>
> <action name="mediaFileView"
>    class="org.apache.roller.weblogger.ui.struts2.editor.MediaFileView">
>             <result name="success" type="tiles">.MediaFileView</result>
>             <result name="success.json"
> type="dispatcher">/WEB-INF/jsps/editor/MediaFileViewLight.jsp</result>
>
> <allowed-methods>deleteFolder,..,createNewDirectory</allowed-methods>
> </action>
>
> Also these are needed:
>
> Method flushCache for action maintenance is not allowed!
> Method reset for action maintenance is not allowed!
> Method enable for action pings is not allowed!
> Method pingNow for action pings is not allowed!
>
> ######
>
> The roller.properties in the war has hard coded stuff
>
> mediafiles.storage.dir=/Users/dave/roller_data/mediafiles
> search.index.dir=/Users/dave/roller_data/search-index
>
> but checking the source its
>
> mediafiles.storage.dir=${user.home}/roller_data/mediafiles
> search.index.dir=${user.home}/roller_data/search-index
>
> so not sure on this.
>
> ###
>
> Checking the logs, other than the had coded roller.properties, no errors.
>
>
> Cheers Greg
>
>
> On 6 October 2017 at 13:07, Dave <sn...@gmail.com> wrote:
>
> > I'm going to extend the vote over the weekend.
> >
> > Please review and vote!
> >
> > Dave
> >
> >
> > On Sun, Oct 1, 2017 at 10:47 AM Dave <sn...@gmail.com> wrote:
> >
> > > I've prepared a third release candidate for Roller 5.2.0. This release
> is
> > > primarily a bug fix release, with lots of fixes from Kohei. I have
> > created
> > > a release candidate which you can find here:
> > >
> > >     https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.
> > 2.0-rc-3/
> > >
> > > And the list of issues resolved is here:
> > >
> > >
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12310906&version=12340980
> > >
> > > Thanks to Greg for finding some issues in rc-2. I believe I have fixed
> > all
> > > the problems that he found plus a couple more. Here's what has changed
> > > since rc-2:
> > >
> > >    1. roller.log location now default to the Catalina Base logs
> directory
> > >    2. Added cache "clear" to list of allowed Struts DMI methods
> > >    3. Use namespace not name in struts.xml Chained Actions
> > >    4. Use "var" instead of "id" for some s:iterator tags
> > >    5. Now shows Media File URL correctly in Media File View modal
> > >
> > > I'm currently running this code on rollerweblogger.org and it seems to
> > be
> > > working well.
> > >
> > > Please take a look and vote.
> > >
> > > Thanks,
> > > Dave
> > >
> >
>

Re: [VOTE] Release rc-3 as Roller 5.2.0

Posted by Greg Huber <gr...@gmail.com>.
Dave,

Looks ok, but found some new items.

######

Needs some more allowed methods.

 eg createNewDirectory for the meda files create action.  btw, rather than
creating global-allowed-methods you can add them to the action itself in a
<allowed-methods> :

<action name="mediaFileView"
   class="org.apache.roller.weblogger.ui.struts2.editor.MediaFileView">
            <result name="success" type="tiles">.MediaFileView</result>
            <result name="success.json"
type="dispatcher">/WEB-INF/jsps/editor/MediaFileViewLight.jsp</result>

<allowed-methods>deleteFolder,..,createNewDirectory</allowed-methods>
</action>

Also these are needed:

Method flushCache for action maintenance is not allowed!
Method reset for action maintenance is not allowed!
Method enable for action pings is not allowed!
Method pingNow for action pings is not allowed!

######

The roller.properties in the war has hard coded stuff

mediafiles.storage.dir=/Users/dave/roller_data/mediafiles
search.index.dir=/Users/dave/roller_data/search-index

but checking the source its

mediafiles.storage.dir=${user.home}/roller_data/mediafiles
search.index.dir=${user.home}/roller_data/search-index

so not sure on this.

###

Checking the logs, other than the had coded roller.properties, no errors.


Cheers Greg


On 6 October 2017 at 13:07, Dave <sn...@gmail.com> wrote:

> I'm going to extend the vote over the weekend.
>
> Please review and vote!
>
> Dave
>
>
> On Sun, Oct 1, 2017 at 10:47 AM Dave <sn...@gmail.com> wrote:
>
> > I've prepared a third release candidate for Roller 5.2.0. This release is
> > primarily a bug fix release, with lots of fixes from Kohei. I have
> created
> > a release candidate which you can find here:
> >
> >     https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.
> 2.0-rc-3/
> >
> > And the list of issues resolved is here:
> >
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12310906&version=12340980
> >
> > Thanks to Greg for finding some issues in rc-2. I believe I have fixed
> all
> > the problems that he found plus a couple more. Here's what has changed
> > since rc-2:
> >
> >    1. roller.log location now default to the Catalina Base logs directory
> >    2. Added cache "clear" to list of allowed Struts DMI methods
> >    3. Use namespace not name in struts.xml Chained Actions
> >    4. Use "var" instead of "id" for some s:iterator tags
> >    5. Now shows Media File URL correctly in Media File View modal
> >
> > I'm currently running this code on rollerweblogger.org and it seems to
> be
> > working well.
> >
> > Please take a look and vote.
> >
> > Thanks,
> > Dave
> >
>

Re: [VOTE] Release rc-3 as Roller 5.2.0

Posted by Kohei Nozaki <ko...@nozaki.me>.
Hi Dave, thank you for your effort to make a new release.

I'm checking the rc3 resources and found some issues, I haven't done checking yet though.

* Some unnecessary files are included in the source distribution

I see some files which look unnecessary to include as a release distribution ( https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-3/roller-release-5.2.0-rc-3-source.tar.gz <https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-3/roller-release-5.2.0-rc-3-source.tar.gz> ) as follows. (It looks like a part of Dave's workspace...)

    $ tree -d roller-weblogger-5.2.0-source/tomcat -L 1
    roller-weblogger-5.2.0-source/tomcat
    ├── apache-jmeter-3.2
    ├── conf
    ├── lib
    ├── logs
    ├── rollerdata
    ├── shared
    ├── temp
    ├── temphsperfdata_dave
    ├── webapps
    └── work

* Duplicate declaration of "rome-fetcher" in pom.xml

I see a duplicate dependency declaration and this makes some warning while building as follows:

    [INFO] Scanning for projects...
    [WARNING] 
    [WARNING] Some problems were encountered while building the effective model for org.apache.roller:roller-webapp:war:5.2.0
    [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: com.rometools:rome-fetcher:jar -> duplicate declaration of version ${rome.version} @ org.apache.roller:roller-webapp:[unknown-version], /Users/kyle/src/roller-520-rc3/roller-weblogger-5.2.0-source/app/pom.xml, line 360, column 21

* Some Log4j2 errors

I see the following error when I try to deploy roller.war on Tomcat. I don't know much about Log4j2 but the error looks not so good. Is this ok?

    ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core to the classpath. Using SimpleLogger to log to the console...

And, can you tell me which git / svn repository are you working on the rc3 release? I've checked master branch of https://github.com/apache/roller but it looks like it's not the latest. It would be nice if it was on GitHub because I could send a Pull Request.

p.s. I don't know why but integration test cases don't work on my Mac. It produces "StartupException: ERROR: unable to obtain database connection"... If anyone has any clue about that please tell me.

Thanks,
Kohei

> On Oct 6, 2017, at 21:07, Dave <sn...@gmail.com> wrote:
> 
> I'm going to extend the vote over the weekend.
> 
> Please review and vote!
> 
> Dave
> 
> 
> On Sun, Oct 1, 2017 at 10:47 AM Dave <sn...@gmail.com> wrote:
> 
>> I've prepared a third release candidate for Roller 5.2.0. This release is
>> primarily a bug fix release, with lots of fixes from Kohei. I have created
>> a release candidate which you can find here:
>> 
>>    https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-3/
>> 
>> And the list of issues resolved is here:
>> 
>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310906&version=12340980
>> 
>> Thanks to Greg for finding some issues in rc-2. I believe I have fixed all
>> the problems that he found plus a couple more. Here's what has changed
>> since rc-2:
>> 
>>   1. roller.log location now default to the Catalina Base logs directory
>>   2. Added cache "clear" to list of allowed Struts DMI methods
>>   3. Use namespace not name in struts.xml Chained Actions
>>   4. Use "var" instead of "id" for some s:iterator tags
>>   5. Now shows Media File URL correctly in Media File View modal
>> 
>> I'm currently running this code on rollerweblogger.org and it seems to be
>> working well.
>> 
>> Please take a look and vote.
>> 
>> Thanks,
>> Dave
>>

Re: [VOTE] Release rc-3 as Roller 5.2.0

Posted by Dave <sn...@gmail.com>.
I'm going to extend the vote over the weekend.

Please review and vote!

Dave


On Sun, Oct 1, 2017 at 10:47 AM Dave <sn...@gmail.com> wrote:

> I've prepared a third release candidate for Roller 5.2.0. This release is
> primarily a bug fix release, with lots of fixes from Kohei. I have created
> a release candidate which you can find here:
>
>     https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-3/
>
> And the list of issues resolved is here:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310906&version=12340980
>
> Thanks to Greg for finding some issues in rc-2. I believe I have fixed all
> the problems that he found plus a couple more. Here's what has changed
> since rc-2:
>
>    1. roller.log location now default to the Catalina Base logs directory
>    2. Added cache "clear" to list of allowed Struts DMI methods
>    3. Use namespace not name in struts.xml Chained Actions
>    4. Use "var" instead of "id" for some s:iterator tags
>    5. Now shows Media File URL correctly in Media File View modal
>
> I'm currently running this code on rollerweblogger.org and it seems to be
> working well.
>
> Please take a look and vote.
>
> Thanks,
> Dave
>