You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by Craig Russell <pa...@gmail.com> on 2018/02/11 08:51:49 UTC
secretary workbench bug
Filing the second icla for Kamesh I encountered an exception.
The original icla is a simple <name>.pdf. The second icla is signed with icla.pdf and icla.pdf.asc. I suspect this is the problem.
I can do this manually but I don't think there is a big rush.
Craig
#<NoMethodError: undefined method `legal_name' for nil:NilClass>
/x1/srv/whimsy/www/secretary/workbench/views/actions/icla2.json.rb:112:in `block in _evaluate'
/x1/srv/whimsy/www/secretary/workbench/tasks.rb:9:in `task'
/x1/srv/whimsy/www/secretary/workbench/views/actions/icla2.json.rb:106:in `_evaluate'
/x1/srv/whimsy/www/secretary/workbench/server.rb:94:in `block in <top (required)>'
/x1/srv/whimsy/lib/whimsy/asf/rack.rb:223:in `call'
/usr/local/rvm/gems/ruby-2.4.1/gems/passenger-5.1.12/src/ruby_supportlib/phusion_passenger/rack/out_of_band_gc.rb:48:in `call'
/x1/srv/whimsy/lib/whimsy/asf/rack.rb:148:in `call'
/x1/srv/whimsy/lib/whimsy/asf/rack.rb:79:in `call'
/x1/srv/whimsy/lib/whimsy/asf/rack.rb:254:in `call'
/usr/local/rvm/gems/ruby-2.4.1/gems/passenger-5.1.12/src/ruby_supportlib/phusion_passenger/rack/thread_handler_extension.rb:97:in `process_request'
/usr/local/rvm/gems/ruby-2.4.1/gems/passenger-5.1.12/src/ruby_supportlib/phusion_passenger/request_handler/thread_handler.rb:160:in `accept_and_process_next_request'
/usr/local/rvm/gems/ruby-2.4.1/gems/passenger-5.1.12/src/ruby_supportlib/phusion_passenger/request_handler/thread_handler.rb:113:in `main_loop'
/usr/local/rvm/gems/ruby-2.4.1/gems/passenger-5.1.12/src/ruby_supportlib/phusion_passenger/request_handler.rb:416:in `block (3 levels) in start_threads'
/usr/local/rvm/gems/ruby-2.4.1/gems/passenger-5.1.12/src/ruby_supportlib/phusion_passenger/utils.rb:113:in `block in create_thread_and_abort_on_exception'
Craig L Russell
papajdo@gmail.com
1220 University Ave
San Jose, CA 95126
Re: secretary workbench bug
Posted by Craig Russell <ap...@gmail.com>.
That should take care of it.
Thanks again,
Craig
On Feb 12, 2018 04:27, "Sam Ruby" <ru...@intertwingly.net> wrote:
> On Sun, Feb 11, 2018 at 8:21 PM, Craig Russell <ap...@gmail.com>
> wrote:
> > Better but not perfect.
> >
> > renamed existing icla
> > added second icla2/icla.pdf and icla.pdf.asc
> > updated iclas.txt with changed email address
> >
> > failed while updating public name in LDAP. of course there is no LDAP
> entry so this step should not be done. Similarly, it should not attempt to
> change the LDAP entry for email.
> >
> > And the ack message should omit:
> > You can change your password using https://id.apache.org .
> >
> > So this icla is processed (manually sent email) but still needs a tweak.
>
> Tweaked: https://github.com/apache/whimsy/commit/
> 0c01352379c30375c18053b55eac8a1d0d71db3a
>
> > Thanks for hopping on this, Sam
> >
> > Craig
>
> - Sam Ruby
>
> >> On Feb 11, 2018, at 7:05 AM, Sam Ruby <ru...@intertwingly.net> wrote:
> >>
> >> On Sun, Feb 11, 2018 at 3:51 AM, Craig Russell <pa...@gmail.com>
> wrote:
> >>> Filing the second icla for Kamesh I encountered an exception.
> >>>
> >>> The original icla is a simple <name>.pdf. The second icla is signed
> with icla.pdf and icla.pdf.asc. I suspect this is the problem.
> >>>
> >>> I can do this manually but I don't think there is a big rush.
> >>>
> >>> Craig
> >>>
> >>> #<NoMethodError: undefined method `legal_name' for nil:NilClass>
> >>
> >> The problem is that the ICLA wasn't found, so extracting the
> >> legal_name from the ICLA fails.
> >>
> >> The ICLA wasn't found as it was attempted to be located by id, and
> >> this individual is not a committer.
> >>
> >> I made a fix to match based on original email address too, and
> >> improved the error message when it fails:
> >>
> >> https://github.com/apache/whimsy/commit/ecbacc3fa3e4be15bcf61e0de2d541
> e700f8fbb2
> >>
> >> I've verified that this fixes the problem reported, but haven't tested
> >> that the actual commit will succeed.
> >>
> >> - Sam Ruby
> >
> > Craig L Russell
> > Secretary, Apache Software Foundation
> > clr@apache.org http://db.apache.org/jdo
> >
>
Re: secretary workbench bug
Posted by Sam Ruby <ru...@intertwingly.net>.
On Sun, Feb 11, 2018 at 8:21 PM, Craig Russell <ap...@gmail.com> wrote:
> Better but not perfect.
>
> renamed existing icla
> added second icla2/icla.pdf and icla.pdf.asc
> updated iclas.txt with changed email address
>
> failed while updating public name in LDAP. of course there is no LDAP entry so this step should not be done. Similarly, it should not attempt to change the LDAP entry for email.
>
> And the ack message should omit:
> You can change your password using https://id.apache.org .
>
> So this icla is processed (manually sent email) but still needs a tweak.
Tweaked: https://github.com/apache/whimsy/commit/0c01352379c30375c18053b55eac8a1d0d71db3a
> Thanks for hopping on this, Sam
>
> Craig
- Sam Ruby
>> On Feb 11, 2018, at 7:05 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>>
>> On Sun, Feb 11, 2018 at 3:51 AM, Craig Russell <pa...@gmail.com> wrote:
>>> Filing the second icla for Kamesh I encountered an exception.
>>>
>>> The original icla is a simple <name>.pdf. The second icla is signed with icla.pdf and icla.pdf.asc. I suspect this is the problem.
>>>
>>> I can do this manually but I don't think there is a big rush.
>>>
>>> Craig
>>>
>>> #<NoMethodError: undefined method `legal_name' for nil:NilClass>
>>
>> The problem is that the ICLA wasn't found, so extracting the
>> legal_name from the ICLA fails.
>>
>> The ICLA wasn't found as it was attempted to be located by id, and
>> this individual is not a committer.
>>
>> I made a fix to match based on original email address too, and
>> improved the error message when it fails:
>>
>> https://github.com/apache/whimsy/commit/ecbacc3fa3e4be15bcf61e0de2d541e700f8fbb2
>>
>> I've verified that this fixes the problem reported, but haven't tested
>> that the actual commit will succeed.
>>
>> - Sam Ruby
>
> Craig L Russell
> Secretary, Apache Software Foundation
> clr@apache.org http://db.apache.org/jdo
>
Re: secretary workbench bug
Posted by Craig Russell <ap...@gmail.com>.
Better but not perfect.
renamed existing icla
added second icla2/icla.pdf and icla.pdf.asc
updated iclas.txt with changed email address
failed while updating public name in LDAP. of course there is no LDAP entry so this step should not be done. Similarly, it should not attempt to change the LDAP entry for email.
And the ack message should omit:
You can change your password using https://id.apache.org .
So this icla is processed (manually sent email) but still needs a tweak.
Thanks for hopping on this, Sam
Craig
> On Feb 11, 2018, at 7:05 AM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Sun, Feb 11, 2018 at 3:51 AM, Craig Russell <pa...@gmail.com> wrote:
>> Filing the second icla for Kamesh I encountered an exception.
>>
>> The original icla is a simple <name>.pdf. The second icla is signed with icla.pdf and icla.pdf.asc. I suspect this is the problem.
>>
>> I can do this manually but I don't think there is a big rush.
>>
>> Craig
>>
>> #<NoMethodError: undefined method `legal_name' for nil:NilClass>
>
> The problem is that the ICLA wasn't found, so extracting the
> legal_name from the ICLA fails.
>
> The ICLA wasn't found as it was attempted to be located by id, and
> this individual is not a committer.
>
> I made a fix to match based on original email address too, and
> improved the error message when it fails:
>
> https://github.com/apache/whimsy/commit/ecbacc3fa3e4be15bcf61e0de2d541e700f8fbb2
>
> I've verified that this fixes the problem reported, but haven't tested
> that the actual commit will succeed.
>
> - Sam Ruby
Craig L Russell
Secretary, Apache Software Foundation
clr@apache.org http://db.apache.org/jdo
Re: secretary workbench bug
Posted by Sam Ruby <ru...@intertwingly.net>.
On Sun, Feb 11, 2018 at 3:51 AM, Craig Russell <pa...@gmail.com> wrote:
> Filing the second icla for Kamesh I encountered an exception.
>
> The original icla is a simple <name>.pdf. The second icla is signed with icla.pdf and icla.pdf.asc. I suspect this is the problem.
>
> I can do this manually but I don't think there is a big rush.
>
> Craig
>
> #<NoMethodError: undefined method `legal_name' for nil:NilClass>
The problem is that the ICLA wasn't found, so extracting the
legal_name from the ICLA fails.
The ICLA wasn't found as it was attempted to be located by id, and
this individual is not a committer.
I made a fix to match based on original email address too, and
improved the error message when it fails:
https://github.com/apache/whimsy/commit/ecbacc3fa3e4be15bcf61e0de2d541e700f8fbb2
I've verified that this fixes the problem reported, but haven't tested
that the actual commit will succeed.
- Sam Ruby