You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Guangya Liu (JIRA)" <ji...@apache.org> on 2016/12/06 16:23:58 UTC

[jira] [Updated] (MESOS-6730) Reserve operation should validate reserved resource role against resource allocationInfo role

     [ https://issues.apache.org/jira/browse/MESOS-6730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guangya Liu updated MESOS-6730:
-------------------------------
    Description: 
When doing dynamic reservation validation, the current logic is make sure the reserved resources role is same as the framework role: https://github.com/apache/mesos/blob/1.1.x/src/master/validation.cpp#L1458

{code}
  if (frameworkRole.isSome() && resource.role() != frameworkRole.get()) {
      return Error(
          "A reserve operation was attempted for a resource with role"
          " '" + resource.role() + "', but the framework can only reserve"
          " resources with role '" + frameworkRole.get() + "'");
    }
{code}

With multi-role framework, we should validate reserved resource role same as resource allocation role.

Please make sure distinguish dynamic reservation with framework and http endpoint. If dynamic reservation was triggered by a framework, then we need to do such validation. If done by the http endpoint, then no need to validate the roles.

  was:
When doing dynamic reservation validation, the current logic is make sure the reserved resources role is same as the framework role: https://github.com/apache/mesos/blob/1.1.x/src/master/validation.cpp#L1458

{code}
  if (frameworkRole.isSome() && resource.role() != frameworkRole.get()) {
      return Error(
          "A reserve operation was attempted for a resource with role"
          " '" + resource.role() + "', but the framework can only reserve"
          " resources with role '" + frameworkRole.get() + "'");
    }
{code}

With multi-role framework, we should validate reserved resource role same as resource allocation role.


> Reserve operation should validate reserved resource role against resource allocationInfo role
> ---------------------------------------------------------------------------------------------
>
>                 Key: MESOS-6730
>                 URL: https://issues.apache.org/jira/browse/MESOS-6730
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Guangya Liu
>
> When doing dynamic reservation validation, the current logic is make sure the reserved resources role is same as the framework role: https://github.com/apache/mesos/blob/1.1.x/src/master/validation.cpp#L1458
> {code}
>   if (frameworkRole.isSome() && resource.role() != frameworkRole.get()) {
>       return Error(
>           "A reserve operation was attempted for a resource with role"
>           " '" + resource.role() + "', but the framework can only reserve"
>           " resources with role '" + frameworkRole.get() + "'");
>     }
> {code}
> With multi-role framework, we should validate reserved resource role same as resource allocation role.
> Please make sure distinguish dynamic reservation with framework and http endpoint. If dynamic reservation was triggered by a framework, then we need to do such validation. If done by the http endpoint, then no need to validate the roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)