You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/10 11:00:26 UTC
[GitHub] [superset] lkm opened a new pull request #14069: feat: impersonate supports in trino engine
lkm opened a new pull request #14069:
URL: https://github.com/apache/superset/pull/14069
### SUMMARY
This will make the Trino engine spec support impersonation. It's basically using existing functionality from Presto/Hive to enable it. It might be help to look at both Trino's [user mapping](https://trino.io/docs/current/security/user-mapping.html?highlight=rules) and [impersonation rules](https://trino.io/docs/current/security/file-system-access-control.html?highlight=rules#impersonation-rules)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
srinify commented on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-882778129
Closing @lkm because it seems, as @dungdm93 pointed out, that this is addressed thru this: https://github.com/apache/superset/pull/14843
Please make a new issue if the merged solution isn't working out for you 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-817119409
# [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=h1) Report
> Merging [#14069](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=desc) (99426ed) into [master](https://codecov.io/gh/apache/superset/commit/fe08b698f5fd4ccc0b511f755007a4aa6db8b3ca?el=desc) (fe08b69) will **decrease** coverage by `0.14%`.
> The diff coverage is `60.00%`.
> :exclamation: Current head 99426ed differs from pull request most recent head 4300535. Consider uploading reports for the commit 4300535 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14069 +/- ##
==========================================
- Coverage 79.35% 79.20% -0.15%
==========================================
Files 939 939
Lines 47538 47547 +9
Branches 5938 5938
==========================================
- Hits 37723 37659 -64
- Misses 9693 9766 +73
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.70% <60.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.74% <60.00%> (-0.01%)` | :arrow_down: |
| presto | `80.46% <60.00%> (-0.01%)` | :arrow_down: |
| python | `81.04% <60.00%> (-0.29%)` | :arrow_down: |
| sqlite | `80.34% <60.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <ø> (ø)` | |
| [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `80.00% <60.00%> (-10.48%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.90% <0.00%> (-0.25%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=footer). Last update [fe08b69...4300535](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify closed pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
srinify closed pull request #14069:
URL: https://github.com/apache/superset/pull/14069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
srinify commented on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-882778129
Closing @lkm because it seems, as @dungdm93 pointed out, that this is addressed thru this: https://github.com/apache/superset/pull/14843
Please make a new issue if the merged solution isn't working out for you 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify closed pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
srinify closed pull request #14069:
URL: https://github.com/apache/superset/pull/14069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-817119409
# [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=h1) Report
> Merging [#14069](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=desc) (99426ed) into [master](https://codecov.io/gh/apache/superset/commit/fe08b698f5fd4ccc0b511f755007a4aa6db8b3ca?el=desc) (fe08b69) will **decrease** coverage by `0.14%`.
> The diff coverage is `60.00%`.
> :exclamation: Current head 99426ed differs from pull request most recent head 90b8c7d. Consider uploading reports for the commit 90b8c7d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14069 +/- ##
==========================================
- Coverage 79.35% 79.20% -0.15%
==========================================
Files 939 939
Lines 47538 47547 +9
Branches 5938 5938
==========================================
- Hits 37723 37659 -64
- Misses 9693 9766 +73
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.70% <60.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.74% <60.00%> (-0.01%)` | :arrow_down: |
| presto | `80.46% <60.00%> (-0.01%)` | :arrow_down: |
| python | `81.04% <60.00%> (-0.29%)` | :arrow_down: |
| sqlite | `80.34% <60.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <ø> (ø)` | |
| [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `80.00% <60.00%> (-10.48%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.90% <0.00%> (-0.25%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=footer). Last update [fe08b69...90b8c7d](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify closed pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
srinify closed pull request #14069:
URL: https://github.com/apache/superset/pull/14069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-817119409
# [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=h1) Report
> Merging [#14069](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=desc) (99426ed) into [master](https://codecov.io/gh/apache/superset/commit/fe08b698f5fd4ccc0b511f755007a4aa6db8b3ca?el=desc) (fe08b69) will **decrease** coverage by `0.28%`.
> The diff coverage is `60.00%`.
> :exclamation: Current head 99426ed differs from pull request most recent head 90b8c7d. Consider uploading reports for the commit 90b8c7d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14069 +/- ##
==========================================
- Coverage 79.35% 79.06% -0.29%
==========================================
Files 939 939
Lines 47538 47547 +9
Branches 5938 5938
==========================================
- Hits 37723 37594 -129
- Misses 9693 9831 +138
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.74% <60.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.78% <60.00%> (-0.54%)` | :arrow_down: |
| sqlite | `80.34% <60.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <ø> (ø)` | |
| [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `80.00% <60.00%> (-10.48%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.44% <0.00%> (-1.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.28% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=footer). Last update [fe08b69...90b8c7d](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dungdm93 commented on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
dungdm93 commented on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-859613829
/close because of #14843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-817119409
# [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=h1) Report
> Merging [#14069](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=desc) (99426ed) into [master](https://codecov.io/gh/apache/superset/commit/fe08b698f5fd4ccc0b511f755007a4aa6db8b3ca?el=desc) (fe08b69) will **decrease** coverage by `0.52%`.
> The diff coverage is `60.00%`.
> :exclamation: Current head 99426ed differs from pull request most recent head 90b8c7d. Consider uploading reports for the commit 90b8c7d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14069 +/- ##
==========================================
- Coverage 79.35% 78.82% -0.53%
==========================================
Files 939 939
Lines 47538 47520 -18
Branches 5938 5938
==========================================
- Hits 37723 37460 -263
- Misses 9693 9938 +245
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.34% <60.00%> (-0.98%)` | :arrow_down: |
| sqlite | `80.34% <60.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <ø> (ø)` | |
| [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `80.00% <60.00%> (-10.48%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-22.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=footer). Last update [fe08b69...90b8c7d](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
srinify commented on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-882778129
Closing @lkm because it seems, as @dungdm93 pointed out, that this is addressed thru this: https://github.com/apache/superset/pull/14843
Please make a new issue if the merged solution isn't working out for you 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-817119409
# [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=h1) Report
> Merging [#14069](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=desc) (99426ed) into [master](https://codecov.io/gh/apache/superset/commit/fe08b698f5fd4ccc0b511f755007a4aa6db8b3ca?el=desc) (fe08b69) will **decrease** coverage by `0.26%`.
> The diff coverage is `60.00%`.
> :exclamation: Current head 99426ed differs from pull request most recent head 90b8c7d. Consider uploading reports for the commit 90b8c7d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14069 +/- ##
==========================================
- Coverage 79.35% 79.08% -0.27%
==========================================
Files 939 939
Lines 47538 47547 +9
Branches 5938 5938
==========================================
- Hits 37723 37604 -119
- Misses 9693 9821 +128
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.70% <60.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.74% <60.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.82% <60.00%> (-0.50%)` | :arrow_down: |
| sqlite | `80.34% <60.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <ø> (ø)` | |
| [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `80.00% <60.00%> (-10.48%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.44% <0.00%> (-1.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=footer). Last update [fe08b69...90b8c7d](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stale[bot] commented on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-859200746
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14069: feat: impersonate supports in trino engine
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-817119409
# [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=h1) Report
> Merging [#14069](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=desc) (3a26139) into [master](https://codecov.io/gh/apache/superset/commit/fe08b698f5fd4ccc0b511f755007a4aa6db8b3ca?el=desc) (fe08b69) will **decrease** coverage by `0.26%`.
> The diff coverage is `60.00%`.
> :exclamation: Current head 3a26139 differs from pull request most recent head 4300535. Consider uploading reports for the commit 4300535 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14069 +/- ##
==========================================
- Coverage 79.35% 79.08% -0.27%
==========================================
Files 939 939
Lines 47538 47545 +7
Branches 5938 5938
==========================================
- Hits 37723 37601 -122
- Misses 9693 9823 +130
+ Partials 122 121 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `80.44% <60.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.44% <60.00%> (-0.89%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <ø> (ø)` | |
| [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `80.00% <60.00%> (-10.48%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.50% <0.00%> (-25.07%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.35% <0.00%> (-9.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `84.10% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `81.83% <0.00%> (-5.61%)` | :arrow_down: |
| ... and [39 more](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=footer). Last update [fe08b69...4300535](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org