You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/01 07:13:53 UTC
[GitHub] [superset] villebro commented on a change in pull request #17593: feat: Trino Authentications
villebro commented on a change in pull request #17593:
URL: https://github.com/apache/superset/pull/17593#discussion_r759906069
##########
File path: docs/src/pages/docs/Connecting to Databases/trino.mdx
##########
@@ -8,20 +8,77 @@ version: 1
## Trino
-Supported trino version 352 and higher
-
-The [sqlalchemy-trino](https://pypi.org/project/sqlalchemy-trino/) library is the recommended way to connect to Trino through SQLAlchemy.
-
-The expected connection string is formatted as follows:
+SuperSet supported Trino >=352 via SQLAlchemy by using [sqlalchemy-trino](https://pypi.org/project/sqlalchemy-trino/) library.
Review comment:
Nit: should this be:
```suggestion
Superset supports Trino >=352 via SQLAlchemy by using [sqlalchemy-trino](https://pypi.org/project/sqlalchemy-trino/) library.
```
##########
File path: tests/integration_tests/db_engine_specs/trino_tests.py
##########
@@ -87,3 +89,71 @@ def test_get_extra_params_with_server_cert(self, create_ssl_cert_file_func: Mock
self.assertEqual(connect_args.get("http_scheme"), "https")
self.assertEqual(connect_args.get("verify"), "/path/to/tls.crt")
create_ssl_cert_file_func.assert_called_once_with(database.server_cert)
+
+ @patch("trino.auth.BasicAuthentication")
+ def test_auth_basic(self, auth: Mock):
+ database = Mock()
+
+ auth_params = dict(username="username", password="password",)
+ database.encrypted_extra = json.dumps(
+ dict(auth_method="basic", auth_params=auth_params)
+ )
+
+ params: Dict[str, Any] = {}
+ TrinoEngineSpec.update_encrypted_extra_params(database, params)
+ connect_args = params.setdefault("connect_args", {})
+ self.assertEqual(connect_args.get("http_scheme"), "https")
+ auth.assert_called_once_with(**auth_params)
+
+ @patch("trino.auth.KerberosAuthentication")
+ def test_auth_kerberos(self, auth: Mock):
+ database = Mock()
+
+ auth_params = dict(
+ service_name="superset", mutual_authentication=False, delegate=True,
+ )
+ database.encrypted_extra = json.dumps(
+ dict(auth_method="kerberos", auth_params=auth_params)
+ )
+
+ params: Dict[str, Any] = {}
+ TrinoEngineSpec.update_encrypted_extra_params(database, params)
+ connect_args = params.setdefault("connect_args", {})
+ self.assertEqual(connect_args.get("http_scheme"), "https")
+ auth.assert_called_once_with(**auth_params)
+
+ @patch("trino.auth.JWTAuthentication")
+ def test_auth_jwt(self, auth: Mock):
+ database = Mock()
+
+ auth_params = dict(token="jwt-token-string")
+ database.encrypted_extra = json.dumps(
+ dict(auth_method="jwt", auth_params=auth_params)
+ )
+
+ params: Dict[str, Any] = {}
+ TrinoEngineSpec.update_encrypted_extra_params(database, params)
+ connect_args = params.setdefault("connect_args", {})
+ self.assertEqual(connect_args.get("http_scheme"), "https")
+ auth.assert_called_once_with(**auth_params)
+
+ def test_auth_custom_auth(self):
+ database = Mock()
+ auth_class = Mock()
+
+ auth_params = dict(params1="params1", params2="params2")
+ database.encrypted_extra = json.dumps(
+ dict(auth_method="module:TrinoAuthClass", auth_params=auth_params)
+ )
Review comment:
and here
##########
File path: tests/integration_tests/db_engine_specs/trino_tests.py
##########
@@ -87,3 +89,71 @@ def test_get_extra_params_with_server_cert(self, create_ssl_cert_file_func: Mock
self.assertEqual(connect_args.get("http_scheme"), "https")
self.assertEqual(connect_args.get("verify"), "/path/to/tls.crt")
create_ssl_cert_file_func.assert_called_once_with(database.server_cert)
+
+ @patch("trino.auth.BasicAuthentication")
+ def test_auth_basic(self, auth: Mock):
+ database = Mock()
+
+ auth_params = dict(username="username", password="password",)
Review comment:
nit, I believe we prevalently use this notation in the codebase:
```suggestion
auth_params = {"username": "username", "password": "password"}
```
##########
File path: tests/integration_tests/db_engine_specs/trino_tests.py
##########
@@ -87,3 +89,71 @@ def test_get_extra_params_with_server_cert(self, create_ssl_cert_file_func: Mock
self.assertEqual(connect_args.get("http_scheme"), "https")
self.assertEqual(connect_args.get("verify"), "/path/to/tls.crt")
create_ssl_cert_file_func.assert_called_once_with(database.server_cert)
+
+ @patch("trino.auth.BasicAuthentication")
+ def test_auth_basic(self, auth: Mock):
+ database = Mock()
+
+ auth_params = dict(username="username", password="password",)
+ database.encrypted_extra = json.dumps(
+ dict(auth_method="basic", auth_params=auth_params)
Review comment:
same here
##########
File path: tests/integration_tests/db_engine_specs/trino_tests.py
##########
@@ -87,3 +89,71 @@ def test_get_extra_params_with_server_cert(self, create_ssl_cert_file_func: Mock
self.assertEqual(connect_args.get("http_scheme"), "https")
self.assertEqual(connect_args.get("verify"), "/path/to/tls.crt")
create_ssl_cert_file_func.assert_called_once_with(database.server_cert)
+
+ @patch("trino.auth.BasicAuthentication")
+ def test_auth_basic(self, auth: Mock):
+ database = Mock()
+
+ auth_params = dict(username="username", password="password",)
+ database.encrypted_extra = json.dumps(
+ dict(auth_method="basic", auth_params=auth_params)
+ )
+
+ params: Dict[str, Any] = {}
+ TrinoEngineSpec.update_encrypted_extra_params(database, params)
+ connect_args = params.setdefault("connect_args", {})
+ self.assertEqual(connect_args.get("http_scheme"), "https")
+ auth.assert_called_once_with(**auth_params)
+
+ @patch("trino.auth.KerberosAuthentication")
+ def test_auth_kerberos(self, auth: Mock):
+ database = Mock()
+
+ auth_params = dict(
+ service_name="superset", mutual_authentication=False, delegate=True,
+ )
+ database.encrypted_extra = json.dumps(
+ dict(auth_method="kerberos", auth_params=auth_params)
+ )
+
+ params: Dict[str, Any] = {}
+ TrinoEngineSpec.update_encrypted_extra_params(database, params)
+ connect_args = params.setdefault("connect_args", {})
+ self.assertEqual(connect_args.get("http_scheme"), "https")
+ auth.assert_called_once_with(**auth_params)
+
+ @patch("trino.auth.JWTAuthentication")
+ def test_auth_jwt(self, auth: Mock):
+ database = Mock()
+
+ auth_params = dict(token="jwt-token-string")
+ database.encrypted_extra = json.dumps(
+ dict(auth_method="jwt", auth_params=auth_params)
+ )
Review comment:
here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org