You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/03 07:05:21 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4617: Provide option to force delete the project
ravening opened a new pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617
### Description
Provide a cleanup flag so that the project will
be deleted only when there are no resources left
in the project. If users click on delete project
by mistake then everything is deleted.
Ui changes ported from https://github.com/apache/cloudstack-primate/pull/848
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-912539851
<b>Trillian test result (tid-1958)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34884 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4617-t1958-kvm-centos7.zip
Smoke tests completed. 87 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestDeployVmWithAffinityGroup>:teardown | `Error` | 138.15 | test_affinity_groups_projects.py
test_07_project_resources_account_delete | `Error` | 5.43 | test_projects.py
test_08_cleanup_after_project_delete | `Error` | 5.83 | test_projects.py
ContextSuite context=TestProjectResources>:teardown | `Error` | 6.89 | test_projects.py
ContextSuite context=TestProjectSuspendActivate>:teardown | `Error` | 65.97 | test_projects.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-867613801
<b>Trillian Build Failed (tid-1092)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-895053805
ping @ravening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-867599211
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-791901534
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-926332731
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-925233221
Ping @ravening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-901596307
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-901618974
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-925640541
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-882294134
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-925667727
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-882295560
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-912178652
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-925640339
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-926740524
<b>Trillian test result (tid-2193)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37337 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4617-t2193-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-926334685
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-926352338
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-919712082
@ravening can you review and fix the failing project related smoketests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-867599783
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-901615845
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-900942261
@rhtyd @nvazquez @davidjumani done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#discussion_r691177883
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/project/DeleteProjectCmd.java
##########
@@ -48,6 +48,9 @@
@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = ProjectResponse.class, required = true, description = "id of the project to be deleted")
private Long id;
+ @Parameter(name = ApiConstants.CLEANUP, type = CommandType.BOOLEAN, description = "true if all project resources have to be cleaned up, false otherwise")
Review comment:
since 4.16.0.0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-926332731
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#discussion_r714614047
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/project/DeleteProjectCmd.java
##########
@@ -48,6 +48,9 @@
@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = ProjectResponse.class, required = true, description = "id of the project to be deleted")
private Long id;
+ @Parameter(name = ApiConstants.CLEANUP, type = CommandType.BOOLEAN, description = "true if all project resources have to be cleaned up, false otherwise")
Review comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-925638147
@rhtyd @nvazquez fixed travis issues.. can you trigger it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-925566605
> Ping @ravening
@rhtyd will look into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-791905272
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2880
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-926352898
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-902210503
<b>Trillian test result (tid-1709)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51228 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4617-t1709-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 82 look OK, 7 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestDeployVmWithAffinityGroup>:teardown | `Error` | 128.48 | test_affinity_groups_projects.py
test_08_arping_in_ssvm | `Failure` | 5.16 | test_diagnostics.py
test_01_add_primary_storage_disabled_host | `Error` | 0.52 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.20 | test_primary_storage.py
test_07_project_resources_account_delete | `Error` | 4.54 | test_projects.py
test_08_cleanup_after_project_delete | `Error` | 5.96 | test_projects.py
ContextSuite context=TestProjectResources>:teardown | `Error` | 7.03 | test_projects.py
ContextSuite context=TestProjectSuspendActivate>:teardown | `Error` | 91.65 | test_projects.py
test_02_list_snapshots_with_removed_data_store | `Error` | 1.16 | test_snapshots.py
test_01_secure_vm_migration | `Error` | 156.30 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 274.12 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 145.90 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 44.65 | test_vm_life_cycle.py
test_hostha_kvm_host_degraded | `Error` | 697.02 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Error` | 685.67 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#discussion_r565240438
##########
File path: server/src/main/java/com/cloud/projects/ProjectManagerImpl.java
##########
@@ -313,7 +338,29 @@ public boolean deleteProject(long projectId) {
CallContext.current().setProject(project);
_accountMgr.checkAccess(ctx.getCallingAccount(), AccessType.ModifyProject, true, _accountMgr.getAccount(project.getProjectAccountId()));
- return deleteProject(ctx.getCallingAccount(), ctx.getCallingUserId(), project);
+ if (isCleanup != null && isCleanup) {
+ return deleteProject(ctx.getCallingAccount(), ctx.getCallingUserId(), project);
+ } else {
+ List<VMTemplateVO> userTemplates = _templateDao.listByAccountId(project.getProjectAccountId());
+ List<VMSnapshotVO> vmSnapshots = _vmSnapshotDao.listByAccountId(project.getProjectAccountId());
+ List<UserVmVO> vms = _userVmDao.listByAccountId(project.getProjectAccountId());
+ List<VolumeVO> volumes = _volumeDao.findDetachedByAccount(project.getProjectAccountId());
+ List<NetworkVO> networks = _networkDao.listByOwner(project.getProjectAccountId());
+ List<? extends Vpc> vpcs = _vpcMgr.getVpcsForAccount(project.getProjectAccountId());
+
+ Optional<String> message = Stream.of(userTemplates, vmSnapshots, vms, volumes, networks, vpcs)
Review comment:
Overall, LGTM. But would it be better, if we could inform the user about all the resources that are tied to the project as opposed to the first one that's found - by doing something like this:
```
List<String> message = Stream.of(userTemplates, vmSnapshots, vms, volumes, networks, vpcs)
.filter(entity -> !entity.isEmpty())
.map(entity -> entity.size() + " " + entity.get(0).getEntityType().getSimpleName())
.collect(Collectors.toList());
...
String msg = String.join(",", message) + " to clean up";
CloudRuntimeException e = new CloudRuntimeException("Can't delete the project yet because it has " + msg);
...
```
Such that the end error would look like:
Or is this too much info??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#discussion_r691177883
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/project/DeleteProjectCmd.java
##########
@@ -48,6 +48,9 @@
@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = ProjectResponse.class, required = true, description = "id of the project to be deleted")
private Long id;
+ @Parameter(name = ApiConstants.CLEANUP, type = CommandType.BOOLEAN, description = "true if all project resources have to be cleaned up, false otherwise")
Review comment:
since 4.16.0.0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-912214584
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-912213390
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-887170819
Hi @ravening can you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-901596460
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-925245730
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-925247082
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-925298617
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-902417521
@ravening Can you please update the smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-882294461
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-900942261
@rhtyd @nvazquez @davidjumani done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-926335881
<b>Trillian Build Failed (tid-2191)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-901618879
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#discussion_r567756138
##########
File path: server/src/main/java/com/cloud/projects/ProjectManagerImpl.java
##########
@@ -313,7 +338,29 @@ public boolean deleteProject(long projectId) {
CallContext.current().setProject(project);
_accountMgr.checkAccess(ctx.getCallingAccount(), AccessType.ModifyProject, true, _accountMgr.getAccount(project.getProjectAccountId()));
- return deleteProject(ctx.getCallingAccount(), ctx.getCallingUserId(), project);
+ if (isCleanup != null && isCleanup) {
+ return deleteProject(ctx.getCallingAccount(), ctx.getCallingUserId(), project);
+ } else {
+ List<VMTemplateVO> userTemplates = _templateDao.listByAccountId(project.getProjectAccountId());
+ List<VMSnapshotVO> vmSnapshots = _vmSnapshotDao.listByAccountId(project.getProjectAccountId());
+ List<UserVmVO> vms = _userVmDao.listByAccountId(project.getProjectAccountId());
+ List<VolumeVO> volumes = _volumeDao.findDetachedByAccount(project.getProjectAccountId());
+ List<NetworkVO> networks = _networkDao.listByOwner(project.getProjectAccountId());
+ List<? extends Vpc> vpcs = _vpcMgr.getVpcsForAccount(project.getProjectAccountId());
+
+ Optional<String> message = Stream.of(userTemplates, vmSnapshots, vms, volumes, networks, vpcs)
Review comment:
@Pearl1594 I can do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-791901416
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-912196980
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-912178480
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti closed pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
sureshanaparti closed pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-926335730
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4617: Provide option to force delete the project
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4617:
URL: https://github.com/apache/cloudstack/pull/4617#issuecomment-882296421
@ravening Can you fix the conflicts ? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org