You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/15 10:14:13 UTC

[GitHub] [superset] villebro commented on a change in pull request #15172: fix(dashboard): Prevent rerendering View Query modal on window resize

villebro commented on a change in pull request #15172:
URL: https://github.com/apache/superset/pull/15172#discussion_r651649392



##########
File path: superset-frontend/src/explore/components/controls/ViewQueryModal.tsx
##########
@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React, { useEffect, useState } from 'react';
+import React, { useEffect, useState, useCallback } from 'react';

Review comment:
       This doesn't appear to be needed here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org