You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by ka...@apache.org on 2013/05/23 21:04:48 UTC

svn commit: r1485827 - in /db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql: build.xml dictionary/DDUtils.java

Author: kahatlen
Date: Thu May 23 19:04:48 2013
New Revision: 1485827

URL: http://svn.apache.org/r1485827
Log:
DERBY-5840: Clean up compiler warnings introduced by using Java 5 language features

Fix warning in DDUtils by using Hashtable's constructor instead of
clone() for type-safety.

Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/build.xml
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/dictionary/DDUtils.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/build.xml
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/build.xml?rev=1485827&r1=1485826&r2=1485827&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/build.xml (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/build.xml Thu May 23 19:04:48 2013
@@ -53,7 +53,7 @@
         <pathelement path="${java16compile.classpath}"/>
       </classpath>
       <include name="${derby.dir}/iapi/sql/**"/>
-      <!-- <compilerarg value="-Xlint:unchecked"/> -->
+      <compilerarg value="-Xlint:unchecked"/>
     </javac>
   </target>
 

Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/dictionary/DDUtils.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/dictionary/DDUtils.java?rev=1485827&r1=1485826&r2=1485827&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/dictionary/DDUtils.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/dictionary/DDUtils.java Thu May 23 19:04:48 2013
@@ -186,7 +186,6 @@ public	class	DDUtils
 	**checks whether the foreign key relation ships referential action
 	**is violating the restrictions we have in the current system.
 	**/
-    @SuppressWarnings("unchecked")
 	public static void validateReferentialActions
     (
 		DataDictionary	dd,
@@ -235,7 +234,8 @@ public	class	DDUtils
 		int currentSelfRefValue = getCurrentDeleteConnections(dd, td, -1, deleteConnHashtable, false, true);
 		validateDeleteConnection(dd, td, refTd, 
 								 refAction, 
-								 deleteConnHashtable, (Hashtable<String,Integer>) deleteConnHashtable.clone(),
+                                 deleteConnHashtable,
+                                 new Hashtable<String, Integer>(deleteConnHashtable),
 								 true, myConstraintName, false , 
 								 new StringBuffer(0), refTableName,
 								 isSelfReferencingFk,