You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "RongtongJin (via GitHub)" <gi...@apache.org> on 2026/06/01 06:15:06 UTC

[PR] [ISSUE #10410] Fix RocksDBOptionsFactoryTest compile failure [rocketmq]

RongtongJin opened a new pull request, #10411:
URL: https://github.com/apache/rocketmq/pull/10411

   ### Which Issue(s) This PR Fixes
   
   Fixes #10410
   
   ### Brief Description
   
   `RocksDBOptionsFactoryTest` referenced a non-existent `ConsumeQueueCompactionFilterFactory` and called a non-existent overload of `RocksDBOptionsFactory.createCQCFOptions`, causing `rocketmq-store` test compilation to fail.
   
   This PR updates the test to call the current `createCQCFOptions(MessageStore)` API directly.
   
   ### How Did You Test This Change?
   
   - `git diff --check`
   - `mvn -pl store -am -DskipTests test-compile`
   - `mvn -pl common,remoting,store -Dtest=org.apache.rocketmq.store.rocksdb.RocksDBOptionsFactoryTest -Dsurefire.failIfNoSpecifiedTests=false test`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #10410] Fix RocksDBOptionsFactoryTest compile failure [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10411:
URL: https://github.com/apache/rocketmq/pull/10411#issuecomment-4590168449

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10411?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 47.95%. Comparing base ([`a705dbc`](https://app.codecov.io/gh/apache/rocketmq/commit/a705dbcb1a36aa1b926978c04371d1275be456e8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`23c07c1`](https://app.codecov.io/gh/apache/rocketmq/commit/23c07c19b5246131b19e93af948d46c7f079ed1d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 3 commits behind head on develop.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop   #10411      +/-   ##
   =============================================
   - Coverage      48.03%   47.95%   -0.08%     
   + Complexity     13284    13262      -22     
   =============================================
     Files           1376     1376              
     Lines         100536   100542       +6     
     Branches       12983    12983              
   =============================================
   - Hits           48292    48216      -76     
   - Misses         46326    46396      +70     
   - Partials        5918     5930      +12     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/10411?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #10410] Fix RocksDBOptionsFactoryTest compile failure [rocketmq]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #10411:
URL: https://github.com/apache/rocketmq/pull/10411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org