You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/13 03:58:54 UTC
[GitHub] [doris] yiguolei opened a new pull request, #15893: [improvement](signal) add tid during core dump,the tid is equal to thread id in be.INFO
yiguolei opened a new pull request, #15893:
URL: https://github.com/apache/doris/pull/15893
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15893: [improvement](signal) add tid during core dump,the tid is equal to thread id in be.INFO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15893:
URL: https://github.com/apache/doris/pull/15893#issuecomment-1382710681
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15893: [improvement](signal) add tid during core dump,the tid is equal to thread id in be.INFO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15893:
URL: https://github.com/apache/doris/pull/15893#issuecomment-1382710689
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #15893: [improvement](signal) add tid during core dump,the tid is equal to thread id in be.INFO
Posted by GitBox <gi...@apache.org>.
Gabriel39 merged PR #15893:
URL: https://github.com/apache/doris/pull/15893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15893: [improvement](signal) add tid during core dump,the tid is equal to thread id in be.INFO
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15893:
URL: https://github.com/apache/doris/pull/15893#issuecomment-1381491172
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.47 seconds
load time: 510 seconds
storage size: 17122717023 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230113084805_clickbench_pr_79539.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15893: [improvement](signal) add tid during core dump,the tid is equal to thread id in be.INFO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15893:
URL: https://github.com/apache/doris/pull/15893#discussion_r1068936915
##########
be/src/common/signal_handler.h:
##########
@@ -307,7 +307,15 @@ void DumpSignalInfo(int signal_number, siginfo_t* siginfo) {
formatter.AppendString(")");
formatter.AppendString(" received by PID ");
formatter.AppendUint64(static_cast<uint64>(getpid()), 10);
- formatter.AppendString(" (TID 0x");
+ formatter.AppendString(" (TID ");
+ uint64_t tid;
+#ifdef __APPLE__
+ pthread_threadid_np(nullptr, &tid);
+#else
+ tid = syscall(SYS_gettid);
Review Comment:
warning: use of undeclared identifier 'SYS_gettid' [clang-diagnostic-error]
```cpp
tid = syscall(SYS_gettid);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org