You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Xu-Wentao (via GitHub)" <gi...@apache.org> on 2023/05/08 10:57:39 UTC
[GitHub] [shardingsphere-on-cloud] Xu-Wentao opened a new pull request, #349: refact(pitr): refator pitr cli req
Xu-Wentao opened a new pull request, #349:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/349
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] Refactor
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
refactor pitr cli's req package, move `set header` logic to a func.
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Test is required for the feat/fix PR, unless you have a good reason
2. Doc is required for the feat PR
3. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] wbtlb commented on pull request #349: refactor(pitr): refactor pitr cli req
Posted by "wbtlb (via GitHub)" <gi...@apache.org>.
wbtlb commented on PR #349:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/349#issuecomment-1538204112
approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #349: refact(pitr): refator pitr cli req
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #349:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/349#issuecomment-1538175227
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=349)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=349) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=349&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=349&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #349: refactor(pitr): refactor pitr cli req
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #349:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/349#issuecomment-1538178240
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=349)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=349) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=349&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=349&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #349: refactor(pitr): refactor pitr cli req
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #349:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/349#issuecomment-1538180835
## [Codecov](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/349?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#349](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/349?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8314db) into [main](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/commit/6c3683b3cc842c2652b457a2ca682fcb61f69fc0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c3683b) will **decrease** coverage by `0.21%`.
> The diff coverage is `25.00%`.
> :exclamation: Current head a8314db differs from pull request most recent head e5de73d. Consider uploading reports for the commit e5de73d to get more accurate results
```diff
@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 45.74% 45.54% -0.21%
==========================================
Files 47 48 +1
Lines 5032 5105 +73
==========================================
+ Hits 2302 2325 +23
- Misses 2561 2611 +50
Partials 169 169
```
| [Impacted Files](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pkg/controllers/shardingsphere\_chaos\_controller.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL3NoYXJkaW5nc3BoZXJlX2NoYW9zX2NvbnRyb2xsZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [pitr/cli/pkg/httputils/req.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl0ci9jbGkvcGtnL2h0dHB1dGlscy9yZXEuZ28=) | `21.91% <69.23%> (ø)` | |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/349/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #349: refactor(pitr): refactor pitr cli req
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #349:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/349#issuecomment-1538177689
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=349)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=349&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=349) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=349&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=349&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org