[jira] [Comment Edited] (ARTEMIS-2751) Call to AMQPMessage.setValidatedUserID does nothing

["Viktor Kolomeyko (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100093#comment-17100093 ] 

Viktor Kolomeyko edited comment on ARTEMIS-2751 at 5/5/20, 5:12 PM:
--------------------------------------------------------------------

Thanks [~robbie]

ARTEMIS-1092 says "When populate-validated-user = true AMQP messages can cause exceptions." Would you know which exception that was?

Also I see {{AMQPMessage}} has method \{{putStringProperty}} so this is not an immutable data construct. That said what would be the harm of populating validating user on the server side?


was (Author: vkolomeyko):
Thanks [~robbie]

ARTEMIS-1092 says "When populate-validated-user = true AMQP messages can cause exceptions." Would you know which exception that was?

Also I see {{AMQPMessage}} has method {{putStringProperty }}so this is not an immutable data construct. That said what would be the harm of populating validating user on the server side?

> Call to AMQPMessage.setValidatedUserID does nothing
> ---------------------------------------------------
>
>                 Key: ARTEMIS-2751
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2751
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.12.0
>            Reporter: Viktor Kolomeyko
>            Priority: Major
>
> Method {{setValidatedUserID}} is not overridden for {{AMQPMessage}} class - therefore it calls parent implementation which does nothing.
> On the other hand: {{org.apache.activemq.artemis.core.message.impl.CoreMessage#setValidatedUserID}} does the right thing and correctly retains validated user information as supplied by {{org.apache.activemq.artemis.core.server.impl.ServerSessionImpl#doSend}}
>  This deficiency prevents from reading {{org.apache.activemq.artemis.api.core.Message#HDR_VALIDATED_USER}} attribute when it is received via AMQP protocol. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)