You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/29 06:23:27 UTC
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1139: fix: sleep more time for apisix to sync data from etcd in e2e test
membphis commented on a change in pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#discussion_r549582736
##########
File path: api/test/docker/apisix_config.yaml
##########
@@ -42,6 +42,7 @@ apisix:
nginx_config:
error_log_level: "debug"
+ worker_processes: "1"
Review comment:
need a comment, only for debug now
##########
File path: api/test/e2e/global_rule_test.go
##########
@@ -79,7 +80,7 @@ func TestGlobalRule(t *testing.T) {
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
ExpectHeaders: map[string]string{"X-VERSION": "1.0"},
- Sleep: sleepTime,
+ Sleep: longSleepTime,
Review comment:
And please update other similar points
##########
File path: api/test/e2e/global_rule_test.go
##########
@@ -79,7 +80,7 @@ func TestGlobalRule(t *testing.T) {
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
ExpectHeaders: map[string]string{"X-VERSION": "1.0"},
- Sleep: sleepTime,
+ Sleep: longSleepTime,
Review comment:
need some comment too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org