You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Udara Liyanage <ud...@wso2.com> on 2014/10/06 06:34:46 UTC
key/alias is hardcoded TopologyBuilder
Hi Martin,
Noticed that key is hard coded in Topologybuilder.java for some reason or
may be some testing purpose. Should n't this be messConfigApp.getAlias().
If so, I can make the change and commit. Could someone confirm whether it
is done with purpose or not?
1. try {
2.
3. TopologyManager.acquireWriteLock();
4. String key = "compositeApplicationAlias"; //app.getAlias()
5. topology.addConfigCompositeApplication(key, messConfigApp)
;
6. TopologyManager.updateTopology(topology);
7. } finally {
8. TopologyManager.releaseWriteLock();
9. }
Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware
web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897
RE: key/alias is hardcoded TopologyBuilder
Posted by "Martin Eppel (meppel)" <me...@cisco.com>.
+1, absolutely, this a reminiscent from my original POC
From: isuruh@wso2.com [mailto:isuruh@wso2.com] On Behalf Of Isuru Haththotuwa
Sent: Sunday, October 05, 2014 9:47 PM
To: Reka Thirunavukkarasu
Cc: Udara Liyanage; dev; Martin Eppel (meppel)
Subject: Re: key/alias is hardcoded TopologyBuilder
On Mon, Oct 6, 2014 at 10:10 AM, Reka Thirunavukkarasu <re...@wso2.com>> wrote:
Hi Udara,
AFAIK, this is obsolete code segment as of what we are doing now..
@Martin/IsuruH/Udara
Shall we remove the code segment that we are not using from grouping branch? Since we are having sonar integrated, it would be good to execute sonar in our grouping branch too. If we remove the unused code, then it will be easy to track the newly added code.
+1. This will help in to clean up the code.
Thanks,
Reka
On Mon, Oct 6, 2014 at 10:04 AM, Udara Liyanage <ud...@wso2.com>> wrote:
Hi Martin,
Noticed that key is hard coded in Topologybuilder.java for some reason or may be some testing purpose. Should n't this be messConfigApp.getAlias(). If so, I can make the change and commit. Could someone confirm whether it is done with purpose or not?
1. try {
2.
3. TopologyManager.acquireWriteLock();
4. String key = "compositeApplicationAlias"; //app.getAlias()
5. topology.addConfigCompositeApplication(key, messConfigApp);
6. TopologyManager.updateTopology(topology);
7. } finally {
8. TopologyManager.releaseWriteLock();
9. }
Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com<http://wso2.com/>
lean. enterprise. middleware
web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897
--
Reka Thirunavukkarasu
Senior Software Engineer,
WSO2, Inc.:http://wso2.com,
Mobile: +94776442007
--
<tel:%2B94776442007>
<tel:%2B94776442007>
Thanks and Regards,
Isuru H.
<tel:%2B94776442007>
+94 716 358 048<tel:%2B94776442007>
Re: key/alias is hardcoded TopologyBuilder
Posted by Isuru Haththotuwa <is...@apache.org>.
On Mon, Oct 6, 2014 at 10:10 AM, Reka Thirunavukkarasu <re...@wso2.com>
wrote:
> Hi Udara,
>
> AFAIK, this is obsolete code segment as of what we are doing now..
>
> @Martin/IsuruH/Udara
> Shall we remove the code segment that we are not using from grouping
> branch? Since we are having sonar integrated, it would be good to execute
> sonar in our grouping branch too. If we remove the unused code, then it
> will be easy to track the newly added code.
>
+1. This will help in to clean up the code.
>
> Thanks,
> Reka
>
> On Mon, Oct 6, 2014 at 10:04 AM, Udara Liyanage <ud...@wso2.com> wrote:
>
>> Hi Martin,
>>
>> Noticed that key is hard coded in Topologybuilder.java for some reason or
>> may be some testing purpose. Should n't this be messConfigApp.getAlias().
>> If so, I can make the change and commit. Could someone confirm whether it
>> is done with purpose or not?
>>
>> 1. try {
>> 2.
>> 3. TopologyManager.acquireWriteLock();
>> 4. String key = "compositeApplicationAlias";
>> //app.getAlias()
>> 5. topology.addConfigCompositeApplication(key,
>> messConfigApp);
>> 6. TopologyManager.updateTopology(topology);
>> 7. } finally {
>> 8. TopologyManager.releaseWriteLock();
>> 9. }
>>
>>
>>
>>
>> Udara Liyanage
>> Software Engineer
>> WSO2, Inc.: http://wso2.com
>> lean. enterprise. middleware
>>
>> web: http://udaraliyanage.wordpress.com
>> phone: +94 71 443 6897
>>
>
>
>
> --
> Reka Thirunavukkarasu
> Senior Software Engineer,
> WSO2, Inc.:http://wso2.com,
> Mobile: +94776442007
>
> --
> <%2B94776442007>
> Thanks and Regards,
>
> Isuru H.
> <%2B94776442007>
> +94 716 358 048 <%2B94776442007>* <http://wso2.com/>*
>
>
> * <http://wso2.com/>*
>
>
>
Re: key/alias is hardcoded TopologyBuilder
Posted by Reka Thirunavukkarasu <re...@wso2.com>.
Hi Udara,
AFAIK, this is obsolete code segment as of what we are doing now..
@Martin/IsuruH/Udara
Shall we remove the code segment that we are not using from grouping
branch? Since we are having sonar integrated, it would be good to execute
sonar in our grouping branch too. If we remove the unused code, then it
will be easy to track the newly added code.
Thanks,
Reka
On Mon, Oct 6, 2014 at 10:04 AM, Udara Liyanage <ud...@wso2.com> wrote:
> Hi Martin,
>
> Noticed that key is hard coded in Topologybuilder.java for some reason or
> may be some testing purpose. Should n't this be messConfigApp.getAlias().
> If so, I can make the change and commit. Could someone confirm whether it
> is done with purpose or not?
>
> 1. try {
> 2.
> 3. TopologyManager.acquireWriteLock();
> 4. String key = "compositeApplicationAlias";
> //app.getAlias()
> 5. topology.addConfigCompositeApplication(key,
> messConfigApp);
> 6. TopologyManager.updateTopology(topology);
> 7. } finally {
> 8. TopologyManager.releaseWriteLock();
> 9. }
>
>
>
>
> Udara Liyanage
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean. enterprise. middleware
>
> web: http://udaraliyanage.wordpress.com
> phone: +94 71 443 6897
>
--
Reka Thirunavukkarasu
Senior Software Engineer,
WSO2, Inc.:http://wso2.com,
Mobile: +94776442007