You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ajantha-bhat (via GitHub)" <gi...@apache.org> on 2023/04/10 15:19:04 UTC
[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6661: Core: Support delete file stats in partitions metadata table
ajantha-bhat commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1161811991
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -90,54 +118,60 @@ private DataTask task(StaticTableScan scan) {
private static StaticDataTask.Row convertPartition(Partition partition) {
return StaticDataTask.Row.of(
- partition.key, partition.specId, partition.dataRecordCount, partition.dataFileCount);
+ partition.key,
+ partition.specId,
+ partition.dataRecordCount,
+ partition.dataFileCount,
+ partition.posDeleteRecordCount,
+ partition.posDeleteFileCount,
+ partition.eqDeleteRecordCount,
+ partition.eqDeleteFileCount);
}
private static Iterable<Partition> partitions(Table table, StaticTableScan scan) {
Types.StructType normalizedPartitionType = Partitioning.partitionType(table);
PartitionMap partitions = new PartitionMap();
- // cache a position map needed by each partition spec to normalize partitions to final schema
- Map<Integer, int[]> normalizedPositionsBySpec =
- Maps.newHashMapWithExpectedSize(table.specs().size());
+ try (CloseableIterable<DataFile> datafiles = planDataFiles(scan);
Review Comment:
I wanted to just keep `planFiles` which returns `CloseableIterable<ContentFile<?>>` but I couldn't' succeed at it during transforming it into `ParallelIterable`
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -90,54 +118,60 @@ private DataTask task(StaticTableScan scan) {
private static StaticDataTask.Row convertPartition(Partition partition) {
return StaticDataTask.Row.of(
- partition.key, partition.specId, partition.dataRecordCount, partition.dataFileCount);
+ partition.key,
+ partition.specId,
+ partition.dataRecordCount,
+ partition.dataFileCount,
+ partition.posDeleteRecordCount,
+ partition.posDeleteFileCount,
+ partition.eqDeleteRecordCount,
+ partition.eqDeleteFileCount);
}
private static Iterable<Partition> partitions(Table table, StaticTableScan scan) {
Types.StructType normalizedPartitionType = Partitioning.partitionType(table);
PartitionMap partitions = new PartitionMap();
- // cache a position map needed by each partition spec to normalize partitions to final schema
- Map<Integer, int[]> normalizedPositionsBySpec =
- Maps.newHashMapWithExpectedSize(table.specs().size());
+ try (CloseableIterable<DataFile> datafiles = planDataFiles(scan);
Review Comment:
I wanted to just keep `planFiles` which returns `CloseableIterable<ContentFile<?>>` but I couldn't succeed at it during transforming it into `ParallelIterable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org