You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/19 18:35:51 UTC
[GitHub] [incubator-superset] betodealmeida opened a new pull request #11751: feat: API endpoint to import dashboards
betodealmeida opened a new pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR adds an API to import dashboards, based on https://github.com/apache/incubator-superset/pull/11749.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Added unit tests.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: https://github.com/apache/incubator-superset/issues/11167
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (05a1b46) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `3.67%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.27% 63.59% -3.68%
===========================================
Files 901 447 -454
Lines 43702 27532 -16170
Branches 4186 0 -4186
===========================================
- Hits 29402 17510 -11892
+ Misses 14196 10022 -4174
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.59% <81.81%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.61% <0.00%> (-0.48%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.95% <0.00%> (-0.27%)` | :arrow_down: |
| [...nd/src/messageToasts/components/ToastPresenter.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdFByZXNlbnRlci50c3g=) | | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | | |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | | |
| ... and [451 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#discussion_r528879357
##########
File path: superset/dashboards/api.py
##########
@@ -641,3 +644,56 @@ def favorite_status(self, **kwargs: Any) -> Response:
for request_id in requested_ids
]
return self.response(200, result=res)
+
+ @expose("/import/", methods=["POST"])
+ @protect()
+ @safe
+ @statsd_metrics
+ def import_(self) -> Response:
+ """Import dashboard(s) with associated charts/datasets/databases
+ ---
+ post:
+ requestBody:
+ content:
+ application/zip:
+ schema:
+ type: string
+ format: binary
+ responses:
+ 200:
+ description: Dashboard import result
+ content:
+ application/json:
+ schema:
+ type: object
+ properties:
+ message:
+ type: string
+ 400:
+ $ref: '#/components/responses/400'
+ 401:
+ $ref: '#/components/responses/401'
+ 422:
+ $ref: '#/components/responses/422'
+ 500:
+ $ref: '#/components/responses/500'
+ """
+ upload = request.files.get("file")
+ if not upload:
+ return self.response_400()
+ with ZipFile(upload) as bundle:
+ contents = {
+ file_name: bundle.read(file_name).decode()
+ for file_name in bundle.namelist()
+ }
+
+ command = ImportDashboardsCommand(contents)
+ try:
+ command.run()
+ return self.response(200, message="OK")
+ except CommandInvalidError as exc:
+ logger.warning("Import dashboard failed")
+ return self.response_422(message=exc.normalized_messages())
+ except Exception as exc: # pylint: disable=broad-except
Review comment:
Will do!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#discussion_r530109739
##########
File path: superset/dashboards/commands/importers/dispatcher.py
##########
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+from typing import Any, Dict
+
+from marshmallow.exceptions import ValidationError
+
+from superset.commands.base import BaseCommand
+from superset.commands.exceptions import CommandInvalidError
+from superset.commands.importers.exceptions import IncorrectVersionError
+from superset.dashboards.commands.importers import v0, v1
+
+logger = logging.getLogger(__name__)
+
+# list of different import formats supported; v0 should be last because
+# the files are not versioned
+command_versions = [
+ v1.ImportDashboardsCommand,
+ v0.ImportDashboardsCommand,
+]
+
+
+class ImportDashboardsCommand(BaseCommand):
+ """
+ Import dashboards.
+
+ This command dispatches the import to different versions of the command
+ until it finds one that matches.
+ """
+
+ # pylint: disable=unused-argument
+ def __init__(self, contents: Dict[str, str], *args: Any, **kwargs: Any):
+ self.contents = contents
+
+ def run(self) -> None:
+ # iterate over all commands until we find a version that can
+ # handle the contents
+ for version in command_versions:
+ command = version(self.contents)
+ try:
+ command.run()
+ return
+ except IncorrectVersionError:
+ # file is not handled by command, skip
+ pass
Review comment:
Added!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (05a1b46) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `3.68%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.27% 63.59% -3.69%
===========================================
Files 901 447 -454
Lines 43702 27532 -16170
Branches 4186 0 -4186
===========================================
- Hits 29402 17509 -11893
+ Misses 14196 10023 -4173
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.59% <81.81%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.61% <0.00%> (-0.48%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.95% <0.00%> (-0.27%)` | :arrow_down: |
| [...end/src/dashboard/util/findFirstParentContainer.js](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRGaXJzdFBhcmVudENvbnRhaW5lci5qcw==) | | |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | | |
| ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (05a1b46) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `3.67%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.27% 63.60% -3.68%
===========================================
Files 901 447 -454
Lines 43702 27532 -16170
Branches 4186 0 -4186
===========================================
- Hits 29402 17511 -11891
+ Misses 14196 10021 -4175
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.60% <81.81%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.95% <0.00%> (-0.27%)` | :arrow_down: |
| [...ntend/src/components/FacePile/FacePile.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvRmFjZVBpbGUuc3Rvcmllcy50c3g=) | | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | | |
| [...plore/components/controls/FixedOrMetricControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaXhlZE9yTWV0cmljQ29udHJvbC5qc3g=) | | |
| [...dashboard/components/gridComponents/new/NewRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdSb3cuanN4) | | |
| ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#discussion_r527644883
##########
File path: tests/dashboards/api_tests.py
##########
@@ -1077,3 +1086,86 @@ def test_export_bundle_not_allowed(self):
db.session.delete(dashboard)
db.session.commit()
+
+ def test_import_dashboard(self):
+ """
+ Dashboard API: Test import dashboard
+ """
+ self.login(username="admin")
+ uri = "api/v1/dashboard/import/"
+
+ buf = BytesIO()
+ with ZipFile(buf, "w") as bundle:
Review comment:
This can be a `pytest. yield_fixture` and then reuse on `test_import_dashboard_invalid`
##########
File path: superset/dashboards/api.py
##########
@@ -641,3 +644,56 @@ def favorite_status(self, **kwargs: Any) -> Response:
for request_id in requested_ids
]
return self.response(200, result=res)
+
+ @expose("/import/", methods=["POST"])
+ @protect()
+ @safe
+ @statsd_metrics
+ def import_(self) -> Response:
+ """Import dashboard(s) with associated charts/datasets/databases
+ ---
+ post:
+ requestBody:
+ content:
+ application/zip:
+ schema:
+ type: string
+ format: binary
+ responses:
+ 200:
+ description: Dashboard import result
+ content:
+ application/json:
+ schema:
+ type: object
+ properties:
+ message:
+ type: string
+ 400:
+ $ref: '#/components/responses/400'
+ 401:
+ $ref: '#/components/responses/401'
+ 422:
+ $ref: '#/components/responses/422'
+ 500:
+ $ref: '#/components/responses/500'
+ """
+ upload = request.files.get("file")
+ if not upload:
+ return self.response_400()
+ with ZipFile(upload) as bundle:
+ contents = {
+ file_name: bundle.read(file_name).decode()
+ for file_name in bundle.namelist()
+ }
+
+ command = ImportDashboardsCommand(contents)
+ try:
+ command.run()
+ return self.response(200, message="OK")
+ except CommandInvalidError as exc:
+ logger.warning("Import dashboard failed")
+ return self.response_422(message=exc.normalized_messages())
+ except Exception as exc: # pylint: disable=broad-except
Review comment:
nit: We could catch any broad exceptions (if it's dificult to pin) on `ImportDashboardsCommand` and reraise a `CommandError` new child like `ImportDashboardsError`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (ed2f7cf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f49525f03ede8a73569ade32caedff01b7790b63?el=desc) (f49525f) will **decrease** coverage by `2.77%`.
> The diff coverage is `76.31%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11751 +/- ##
==========================================
- Coverage 65.69% 62.91% -2.78%
==========================================
Files 905 449 -456
Lines 43862 27615 -16247
Branches 4201 0 -4201
==========================================
- Hits 28816 17375 -11441
+ Misses 14907 10240 -4667
+ Partials 139 0 -139
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.91% <76.31%> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `85.71% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `88.72% <0.00%> (-2.95%)` | :arrow_down: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.90% <33.33%> (+0.07%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `95.28% <33.33%> (+0.04%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.85% <33.33%> (+0.10%)` | :arrow_up: |
| [...perset/dashboards/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvZGlzcGF0Y2hlci5weQ==) | `79.31% <79.31%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `89.28% <100.00%> (+0.82%)` | :arrow_up: |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `91.30% <100.00%> (+0.60%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [f49525f...ed2f7cf](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (6c60165) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `3.82%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.28% 63.46% -3.83%
===========================================
Files 901 447 -454
Lines 43702 27532 -16170
Branches 4186 0 -4186
===========================================
- Hits 29405 17473 -11932
+ Misses 14193 10059 -4134
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.46% <81.81%> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `95.23% <ø> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.09% <0.00%> (-0.14%)` | :arrow_down: |
| [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | | |
| ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#discussion_r528879838
##########
File path: tests/dashboards/api_tests.py
##########
@@ -1077,3 +1086,86 @@ def test_export_bundle_not_allowed(self):
db.session.delete(dashboard)
db.session.commit()
+
+ def test_import_dashboard(self):
+ """
+ Dashboard API: Test import dashboard
+ """
+ self.login(username="admin")
+ uri = "api/v1/dashboard/import/"
+
+ buf = BytesIO()
+ with ZipFile(buf, "w") as bundle:
Review comment:
The bundle in `test_import_dashboard_invalid` is slightly different, the `metadata.yaml` is wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (ed2f7cf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f49525f03ede8a73569ade32caedff01b7790b63?el=desc) (f49525f) will **decrease** coverage by `5.70%`.
> The diff coverage is `76.31%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11751 +/- ##
==========================================
- Coverage 65.69% 59.99% -5.71%
==========================================
Files 905 860 -45
Lines 43862 42139 -1723
Branches 4201 3727 -474
==========================================
- Hits 28816 25281 -3535
- Misses 14907 16858 +1951
+ Partials 139 0 -139
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.43% <ø> (+9.88%)` | :arrow_up: |
| javascript | `?` | |
| python | `62.91% <76.31%> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `85.71% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `88.72% <0.00%> (-2.95%)` | :arrow_down: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.90% <33.33%> (+0.07%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `95.28% <33.33%> (+0.04%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.85% <33.33%> (+0.10%)` | :arrow_up: |
| [...perset/dashboards/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvZGlzcGF0Y2hlci5weQ==) | `79.31% <79.31%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `89.28% <100.00%> (+0.82%)` | :arrow_up: |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `91.30% <100.00%> (+0.60%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [370 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [f49525f...ed2f7cf](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (05a1b46) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `3.94%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.27% 63.33% -3.95%
===========================================
Files 901 901
Lines 43702 43716 +14
Branches 4186 4186
===========================================
- Hits 29402 27687 -1715
- Misses 14196 15849 +1653
- Partials 104 180 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.82% <ø> (ø)` | |
| python | `63.63% <81.81%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [168 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (05a1b46) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `3.68%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.27% 63.59% -3.69%
===========================================
Files 901 447 -454
Lines 43702 27532 -16170
Branches 4186 0 -4186
===========================================
- Hits 29402 17509 -11893
+ Misses 14196 10023 -4173
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.59% <81.81%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.61% <0.00%> (-0.48%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.95% <0.00%> (-0.27%)` | :arrow_down: |
| [...frontend/src/dashboard/util/newEntitiesFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0VudGl0aWVzRnJvbURyb3AuanM=) | | |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | | |
| ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] hughhhh commented on a change in pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#discussion_r530051942
##########
File path: superset/dashboards/commands/importers/dispatcher.py
##########
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+from typing import Any, Dict
+
+from marshmallow.exceptions import ValidationError
+
+from superset.commands.base import BaseCommand
+from superset.commands.exceptions import CommandInvalidError
+from superset.commands.importers.exceptions import IncorrectVersionError
+from superset.dashboards.commands.importers import v0, v1
+
+logger = logging.getLogger(__name__)
+
+# list of different import formats supported; v0 should be last because
+# the files are not versioned
+command_versions = [
+ v1.ImportDashboardsCommand,
+ v0.ImportDashboardsCommand,
+]
+
+
+class ImportDashboardsCommand(BaseCommand):
+ """
+ Import dashboards.
+
+ This command dispatches the import to different versions of the command
+ until it finds one that matches.
+ """
+
+ # pylint: disable=unused-argument
+ def __init__(self, contents: Dict[str, str], *args: Any, **kwargs: Any):
+ self.contents = contents
+
+ def run(self) -> None:
+ # iterate over all commands until we find a version that can
+ # handle the contents
+ for version in command_versions:
+ command = version(self.contents)
+ try:
+ command.run()
+ return
+ except IncorrectVersionError:
+ # file is not handled by command, skip
+ pass
Review comment:
nit: add logger.info stating we are skipping this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (05a1b46) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `3.64%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.27% 63.63% -3.65%
===========================================
Files 901 447 -454
Lines 43702 27532 -16170
Branches 4186 0 -4186
===========================================
- Hits 29402 17519 -11883
+ Misses 14196 10013 -4183
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.63% <81.81%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | | |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | | |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | | |
| [...c/visualizations/FilterBox/FilterBoxChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3hDaGFydFBsdWdpbi5qcw==) | | |
| [...nd/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENvbXBvbmVudFdpZHRoRnJvbURyb3AuanM=) | | |
| [superset-frontend/src/components/styles.ts](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvc3R5bGVzLnRz) | | |
| [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | | |
| [superset-frontend/src/components/DeleteModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVsZXRlTW9kYWwudHN4) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (05a1b46) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `3.64%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.27% 63.63% -3.65%
===========================================
Files 901 447 -454
Lines 43702 27532 -16170
Branches 4186 0 -4186
===========================================
- Hits 29402 17519 -11883
+ Misses 14196 10013 -4183
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.63% <81.81%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [...end/src/dashboard/util/findFirstParentContainer.js](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRGaXJzdFBhcmVudENvbnRhaW5lci5qcw==) | | |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | | |
| [superset-frontend/src/profile/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvaW5kZXgudHN4) | | |
| [...ews/CRUD/annotationlayers/AnnotationLayersList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJzTGlzdC50c3g=) | | |
| [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | | |
| [superset-frontend/src/profile/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLnRzeA==) | | |
| [superset-frontend/src/messageToasts/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29uc3RhbnRzLnRz) | | |
| [...nd/src/messageToasts/components/ToastPresenter.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdFByZXNlbnRlci50c3g=) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (6c60165) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `3.65%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.28% 63.63% -3.66%
===========================================
Files 901 447 -454
Lines 43702 27532 -16170
Branches 4186 0 -4186
===========================================
- Hits 29405 17519 -11886
+ Misses 14193 10013 -4180
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.63% <81.81%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `95.23% <ø> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | | |
| [...rset-frontend/src/dashboard/util/componentTypes.ts](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudFR5cGVzLnRz) | | |
| [superset-frontend/src/explore/dateFilterUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZGF0ZUZpbHRlclV0aWxzLnRz) | | |
| [...ntend/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2FjdGl2ZURhc2hib2FyZEZpbHRlcnMuanM=) | | |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | | |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | | |
| [.../src/explore/components/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9GaWx0ZXJEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
| ... and [447 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (ed2f7cf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f49525f03ede8a73569ade32caedff01b7790b63?el=desc) (f49525f) will **decrease** coverage by `5.49%`.
> The diff coverage is `76.31%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11751 +/- ##
==========================================
- Coverage 65.69% 60.20% -5.50%
==========================================
Files 905 860 -45
Lines 43862 42139 -1723
Branches 4201 3727 -474
==========================================
- Hits 28816 25368 -3448
- Misses 14907 16771 +1864
+ Partials 139 0 -139
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.03% <ø> (+10.47%)` | :arrow_up: |
| javascript | `?` | |
| python | `62.91% <76.31%> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `85.71% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `88.72% <0.00%> (-2.95%)` | :arrow_down: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.90% <33.33%> (+0.07%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `95.28% <33.33%> (+0.04%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.85% <33.33%> (+0.10%)` | :arrow_up: |
| [...perset/dashboards/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvZGlzcGF0Y2hlci5weQ==) | `79.31% <79.31%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `89.28% <100.00%> (+0.82%)` | :arrow_up: |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `91.30% <100.00%> (+0.60%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [369 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [f49525f...ed2f7cf](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (05a1b46) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `4.44%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.27% 62.83% -4.45%
===========================================
Files 901 447 -454
Lines 43702 27530 -16172
Branches 4186 0 -4186
===========================================
- Hits 29402 17298 -12104
+ Misses 14196 10232 -3964
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.83% <81.81%> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `88.72% <ø> (-2.95%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.10% <0.00%> (-25.33%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.53% <0.00%> (-6.94%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [468 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11751: feat: API endpoint to import dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11751:
URL: https://github.com/apache/incubator-superset/pull/11751#issuecomment-730568603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=h1) Report
> Merging [#11751](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=desc) (6c60165) into [SO-1044](https://codecov.io/gh/apache/incubator-superset/commit/9daa0828375d0a63cb7e377d565938896611c890?el=desc) (9daa082) will **decrease** coverage by `4.60%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1044 #11751 +/- ##
===========================================
- Coverage 67.28% 62.67% -4.61%
===========================================
Files 901 447 -454
Lines 43702 27521 -16181
Branches 4186 0 -4186
===========================================
- Hits 29405 17249 -12156
+ Misses 14193 10272 -3921
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.67% <81.81%> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `95.23% <ø> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.66% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `83.48% <81.81%> (-0.19%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [474 more](https://codecov.io/gh/apache/incubator-superset/pull/11751/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=footer). Last update [9daa082...6c60165](https://codecov.io/gh/apache/incubator-superset/pull/11751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org