You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/24 07:01:08 UTC
[GitHub] [commons-numbers] arturobernalg opened a new pull request #87: Minor Improvement:
arturobernalg opened a new pull request #87:
URL: https://github.com/apache/commons-numbers/pull/87
* commons-number
* Add final
* Unnecessary semicolon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-numbers] arturobernalg closed pull request #87: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #87:
URL: https://github.com/apache/commons-numbers/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-numbers] coveralls commented on pull request #87: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #87:
URL: https://github.com/apache/commons-numbers/pull/87#issuecomment-750787703
[](https://coveralls.io/builds/35931903)
Coverage remained the same at 99.637% when pulling **b7283ed175c1c225f4cfce7f84e57f5ec67f75dc on arturobernalg:feature/minor_improvement** into **134133bf7e556e3e5ff631bea0bc350c73d48ae8 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-numbers] aherbert commented on pull request #87: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
aherbert commented on pull request #87:
URL: https://github.com/apache/commons-numbers/pull/87#issuecomment-750902544
The 'final' status of parameters is enforced in the project using PMD rules: `AvoidReassigningParameters`. However we have avoided using final in the code as it adds visual noise to the source code and the PMD rule `MethodArgumentCouldBeFinal` is disabled. There is no benefit of final method arguments to the JVM compiler, which knows about effectively final variables for example those that can be referenced inside lambda statements.
As such it is difficult to see what other modifications are in the PR. Can you remove the use of final for method arguments and then it will be clear what is left?
The use of final for method params is a style choice and you can raise this on the dev mailing list to start a discussion about what is preferred.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-numbers] garydgregory commented on pull request #87: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #87:
URL: https://github.com/apache/commons-numbers/pull/87#issuecomment-751137649
This is my pitch for using final: https://www.google.com/amp/s/garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org