You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/10/05 21:50:06 UTC
[jclouds] Add snapshot plugin repo to jclouds-project (#548)
It's needed by downstream projects such as labs-google and labs-openstack. The commit changing the modernizer config is needed to allow jclouds-project to compile.
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds add-snapshot-plugin-repo
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/548
-- Commit Summary --
* Adding apache-snapshots as a plugin repo
* Overriding modernizer-plugin exclusion file location for jclouds-project
-- File Changes --
M project/pom.xml (32)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/548.patch
https://github.com/jclouds/jclouds/pull/548.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1714](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1714/) ABORTED
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57972485
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #138](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/138/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57949681
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by Andrew Phillips <no...@github.com>.
@andrewgaul This differs from the Checkstyle plugin, which seemingly can find these kind of relative paths.
Log snippet from running `mvn checkstyle:checkstyle -X -pl project` from the jclouds root:
```
[DEBUG] request.getConfigLocation() ../resources/checkstyle.xml
[DEBUG] The resource '../resources/checkstyle.xml' was not found with resourceLo
ader org.codehaus.plexus.resource.loader.JarResourceLoader.
[DEBUG] The resource '../resources/checkstyle.xml' was not found with resourceLo
ader org.codehaus.plexus.resource.loader.ThreadContextClasspathResourceLoader.
[DEBUG] URLResourceLoader: Exception when looking for '../resources/checkstyle.x
ml' at ''
...
[DEBUG] The resource '../resources/checkstyle.xml' was not found with resourceLo
ader org.codehaus.plexus.resource.loader.URLResourceLoader.
[DEBUG] The resource '../resources/checkstyle.xml' was found as C:\Users\aphilli
ps\Workspaces\Personal\jclouds\jclouds\project\..\resources\checkstyle.xml.
```
I'll try to have a look at this later...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57950660
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by Andrew Phillips <no...@github.com>.
Most of the Checkstyle stuff seems to be going on in http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.13/src/main/java/org/apache/maven/plugin/checkstyle/exec/DefaultCheckstyleExecutor.java?view=markup
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57950798
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by Andrew Phillips <no...@github.com>.
Closed #548.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#event-174304577
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-pull-requests #1227 FAILURE
Hm. Doesn't look like it can resolve the local path:
```
[ERROR] Failed to execute goal org.gaul:modernizer-maven-plugin:1.1.0:modernizer (modernizer) on project jclouds-project: Could not find exclusion file: ../resources/modernizer_exclusions.txt -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.gaul:modernizer-maven-plugin:1.1.0:modernizer (modernizer) on project jclouds-project: Could not find exclusion file: ../resources/modernizer_exclusions.txt
```
@andrewgaul Thoughts on that?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57950003
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by Adrian Cole <no...@github.com>.
> @@ -1068,6 +1079,17 @@
> <violationSeverity>warning</violationSeverity>
> </configuration>
> </plugin>
> + <plugin>
> + <groupId>org.gaul</groupId>
> + <artifactId>modernizer-maven-plugin</artifactId>
> + <configuration>
> + <javaVersion>1.7</javaVersion>
> + <!-- in jclouds-project use the local file. ${project.basedir}
> + required here as 1.1.0 of the modernizer plugin can't find the
> + exclusions file otherwise -->
> + <exclusionsFile>${project.basedir}/../resources/modernizer_exclusions.txt</exclusionsFile>
hmm.. how will this affect projects that import this, such as labs?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548/files#r18437610
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1227](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1227/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57949792
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1229](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1229/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57954736
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #140](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/140/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57952748
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by Andrew Phillips <no...@github.com>.
Merged to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=79d4b48d0151667db062a7035b23b28d7a1e1daf).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57955211
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by Andrew Phillips <no...@github.com>.
Setting an absolute path explicitly seems to do the trick. Let's try that...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57952186
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-pull-requests #1229 UNSTABLE
Some [Checkstyle failures](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1229/violations/) here, but look unrelated to this request, it seems.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548#issuecomment-57954892
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by Adrian Cole <ad...@gmail.com>.
thanks for the explanation! lgtm
Re: [jclouds] Add snapshot plugin repo to jclouds-project (#548)
Posted by Andrew Phillips <no...@github.com>.
> @@ -1068,6 +1079,17 @@
> <violationSeverity>warning</violationSeverity>
> </configuration>
> </plugin>
> + <plugin>
> + <groupId>org.gaul</groupId>
> + <artifactId>modernizer-maven-plugin</artifactId>
> + <configuration>
> + <javaVersion>1.7</javaVersion>
> + <!-- in jclouds-project use the local file. ${project.basedir}
> + required here as 1.1.0 of the modernizer plugin can't find the
> + exclusions file otherwise -->
> + <exclusionsFile>${project.basedir}/../resources/modernizer_exclusions.txt</exclusionsFile>
> hmm.. how will this affect projects that import this, such as labs?
This is in the `jclouds-project` project, which should **only** trigger in jclouds/project. All other modules (in jclouds/jclouds and other repos) should inherit from `not-jclouds-project`, which gets the config files from the classpath via a jclouds-resources dep.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/548/files#r18437776